Add new wrapper to Calculator that supports V2API and facets #1381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shifucun
reviewed
Jun 10, 2024
| @@ -101,13 +101,13 @@ func (c *calculator) statVars() []string { | |||
| return statVars | |||
| } | |||
|
|
|||
| func (c *calculator) calculate( | |||
| func (c *Calculator) Calculate( | |||
There was a problem hiding this comment.
calculate should still be an internal function of Calculator? For an interface perspective, the caller should not know the internals/pass the callbacks?
|
This PR can be closed? @n-h-diaz |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a first pass to get the basic functionality working.
I added a new wrapper because the existing wrapper (DerivedSeries) only reads from BT and doesn't support facets (which I think is by design, since I think the primary use case is to combine across imports) or ObsCollection
The new wrapper will only match facets and (like DerivedSeries) will only return one computed response. Since it uses V2API, it also supports ObsCollection without the need for child places.
There are some pending TODOs to clean this up as a follow up, particularly relating to how facets are handled. Going forward, I can further separate the two wrappers, which will avoid precomputing the facets:
(This will simplify a lot of the logic in Calculation.computeCalculation)