Create resolver hierarchy and support chunked calls in recon client. #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pradh
reviewed
Jul 25, 2023
util/src/main/java/org/datacommons/util/CoordinatesResolver.java
Outdated
Show resolved
Hide resolved
util/src/main/java/org/datacommons/util/CoordinatesResolver.java
Outdated
Show resolved
Hide resolved
keyurva
changed the title
pradh
reviewed
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolverbase class with concrete implementations for local, entity and coordinates resolver.ExternalIdResolver. Integration will be done in the next PR.ReconClientnow supports resolving both entities and coordinates. It also partitions requests into manageable chunks and issues the chunked calls in parallel.