Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EuroStatHealth_AlcoholConsumption_Modifications #1145

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

EuroStatHealth_AlcoholConsumption_Modifications #1145

wants to merge 15 commits into from

Conversation

SudhishaK
Copy link

@SudhishaK SudhishaK commented Dec 17, 2024 •
edited
Loading

This PR includes 6 imports:

  1. EuroStatHealth_AlcoholConsumption
  2. EurostatHealth_Tobacco_Consumption
  3. EuroStatHealth_SocialEnvironment
  4. EuroStatHealth_BodyMassIndex
  5. EuroStatHealth_FruitsAndVegetables
  6. EuroStatHealth_PhysicalActivity

krishnaswamypradeep
krishnaswamypradeep approved these changes Dec 20, 2024
View reviewed changes
Copy link

@krishnaswamypradeep krishnaswamypradeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Sudhisha. Looks good.

@SudhishaK SudhishaK requested a review from ajaits December 23, 2024 05:21
@SudhishaK SudhishaK assigned SudhishaK and unassigned n-h-diaz Dec 23, 2024
krishnaswamypradeep
krishnaswamypradeep reviewed Jan 2, 2025
View reviewed changes
Copy link

@krishnaswamypradeep krishnaswamypradeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test file sizes are too high. Make sure to keep less that .5MB file size per import

@krishnaswamypradeep krishnaswamypradeep self-requested a review January 2, 2025 04:29
krishnaswamypradeep
krishnaswamypradeep approved these changes Jan 2, 2025
View reviewed changes
Copy link

@krishnaswamypradeep krishnaswamypradeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Sudhisha. Looks good.

ajaits
ajaits reviewed Jan 10, 2025
View reviewed changes
scripts/eurostat/health_determinants/manifest.json Outdated
"import_specifications": [
{
"import_name": "EuroStatHealth_AlcoholConsumption",
"curator_emails": ["[email protected]"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's leave this blank as notifications is always sent to google alias. We can use this for data from external partners with contacts.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the "curator_emails" as blank. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajaits ajaits ajaits left review comments

@krishnaswamypradeep krishnaswamypradeep krishnaswamypradeep approved these changes

Assignees

@SudhishaK SudhishaK

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SudhishaK @ajaits @krishnaswamypradeep @n-h-diaz