us_hud income 20241127 changes #1126
Conversation
There was a problem hiding this comment.
Please add Copyright section.
There was a problem hiding this comment.
Local requirement.txt file is missing. Can you add the file?
There was a problem hiding this comment.
Still no requirement.txt file in change set!
| if year < 2006: | ||
| return '' | ||
| suffix = str(year)[-2:] | ||
| if year == 2023: | ||
| return 'Section8-FY23.xlsx' # Directly reference 2023 file for download | ||
| elif year == 2024: |
There was a problem hiding this comment.
Why are the year and file name hardcoded? How will the script handle future years file?
There was a problem hiding this comment.
The script does not include any error handling mechanisms. Please add try-catch blocks to handle potential exceptions and prevent the script from crashing unexpectedly.
There was a problem hiding this comment.
The script currently lacks proper logging. This makes it difficult to troubleshoot issues and perform root cause analysis (RCA) in case of errors or unexpected behavior. Please add appropriate logging statements to track the script's execution and identify potential problems.
No description provided.