world_bank_datasets #1075
Open
world_bank_datasets #1075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -334,7 +348,7 @@ def load_stat_vars(stat_var_file): | |||
| else: | |||
| logging.error('SKIPPED stat var row: %s', csv_row) | |||
|
|
|||
| logging.info(svs) | |||
| #logging.info(svs) | |||
There was a problem hiding this comment.
Please remove commented line.
shamimansari1988
approved these changes
Sep 18, 2024
There was a problem hiding this comment.
- Please add Readme.md file
- Update copyright year to 2024
ajaits
reviewed
Sep 18, 2024
| logging.info('Writing response to file %s', response_file) | ||
| json.dump(response, f, indent=2) | ||
| return response | ||
| try: |
There was a problem hiding this comment.
If the download fails for existing data, better to abort the processing as autorefresh with partial data will result in deletions in prod.
There was a problem hiding this comment.
We have one tMCF file and multiple CSV files. So can we add wildcards in CSV Paths instead of referring to each individual CSV file?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auto refresh for https://github.com/datacommonsorg/data/tree/master/scripts/world_bank/datasets (PR#892).