Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix 156: No result for static route overlap check with non-affected versions #167

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

takishida
Copy link
Collaborator

The issue ( #156 ) was actually visible even in the pytest output pasted in the original PR #129.
The last line is of when the provided versions are not affected by CSCwb91766, which is what this check is for.

[Check  1/1] L3out /32 Static Route and BD Subnet Overlap...                                                      FAIL - OUTAGE WARNING!!
  L3out                 /32 Static Route  BD                BD Subnet
  -----                 ----------------  --                ---------
  uni/tn-AA/out-static  81.81.81.81       uni/tn-AA/BD-bd1  81.81.81.1/24

  Recommended Action: Change /32 static route design or target a fixed version
  Reference Document: https://datacenter.github.io/ACI-Pre-Upgrade-Validation-Script/validations/#l3out-32-overlap-with-bd-subnet


[Check  1/1] L3out /32 Static Route and BD Subnet Overlap...                                                      FAIL - OUTAGE WARNING!!
  L3out                 /32 Static Route  BD                BD Subnet
  -----                 ----------------  --                ---------
  uni/tn-AA/out-static  81.81.81.81       uni/tn-AA/BD-bd1  81.81.81.1/24

  Recommended Action: Change /32 static route design or target a fixed version
  Reference Document: https://datacenter.github.io/ACI-Pre-Upgrade-Validation-Script/validations/#l3out-32-overlap-with-bd-subnet


[Check  1/1] L3out /32 Static Route and BD Subnet Overlap...                                                                         PASS
[Check  1/1] L3out /32 Static Route and BD Subnet Overlap...                                                                         PASS
[Check  1/1] L3out /32 Static Route and BD Subnet Overlap...      <--- result missing

After the fix:

[Check  1/1] L3out /32 Static Route and BD Subnet Overlap...                                                      FAIL - OUTAGE WARNING!!
  L3out                 /32 Static Route  BD                BD Subnet
  -----                 ----------------  --                ---------
  uni/tn-AA/out-static  81.81.81.81       uni/tn-AA/BD-bd1  81.81.81.1/24

  Recommended Action: Change /32 static route design or target a fixed version
  Reference Document: https://datacenter.github.io/ACI-Pre-Upgrade-Validation-Script/validations/#l3out-32-overlap-with-bd-subnet


[Check  1/1] L3out /32 Static Route and BD Subnet Overlap...                                                      FAIL - OUTAGE WARNING!!
  L3out                 /32 Static Route  BD                BD Subnet
  -----                 ----------------  --                ---------
  uni/tn-AA/out-static  81.81.81.81       uni/tn-AA/BD-bd1  81.81.81.1/24

  Recommended Action: Change /32 static route design or target a fixed version
  Reference Document: https://datacenter.github.io/ACI-Pre-Upgrade-Validation-Script/validations/#l3out-32-overlap-with-bd-subnet


[Check  1/1] L3out /32 Static Route and BD Subnet Overlap...                                                                         PASS
[Check  1/1] L3out /32 Static Route and BD Subnet Overlap...                                                                         PASS
[Check  1/1] L3out /32 Static Route and BD Subnet Overlap...                                                                         PASS

Also, cleaned up the unnecessary white spaces.

@takishida
Copy link
Collaborator Author

Internal integration tests have also passed.

Copy link
Collaborator

@monrog2 monrog2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good

@monrog2 monrog2 merged commit a786f90 into master Oct 1, 2024
3 checks passed
@monrog2 monrog2 deleted the 156-result-missing-for-static-route-overlap-check branch October 1, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Result output missing of test item 67 "L3out /32 Static Route and BD Subnet Overlap"
2 participants