Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue#125 fixed #161

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

issue#125 fixed #161

wants to merge 2 commits into from

Conversation

jeestr4d
Copy link
Collaborator

Issue #125 fixed , pytest passed in local machine

Copy link
Collaborator

@monrog2 monrog2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Address changes listed
  2. Think about filtering the lldpAdjEp API call to ensure you only get spines, vs tier-2 leaves or any other node types.
  3. Add local pytest output
  4. Were you able to run integration test against the lab fabrics?
  5. Documentation updates are missing

Reminder that you were previously given write access so you should be able to create a new branch directly within this git to put into an MR instead of forking to your own repo.

aci-preupgrade-validation-script.py Outdated Show resolved Hide resolved
aci-preupgrade-validation-script.py Outdated Show resolved Hide resolved
aci-preupgrade-validation-script.py Outdated Show resolved Hide resolved
Copy link
Collaborator Author

@jeestr4d jeestr4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 Address changes listed [DONE]
2 Think about filtering the lldpAdjEp API call to ensure you only get spines, vs tier-2 leaves or any other node types. [DONE]
Added checks to ensure only Tier1 leaf switches would be checked against spines.
3 Add local pytest output [DONE]
Local Test Output
jeestrad@JEESTRAD-M-L6VV ACI-Pre-Upgrade-Validation-Script % python3 -m pytest tests/leaf_to_spine_redundancy_check
========================================================================== test session starts ===========================================================================
platform darwin -- Python 3.9.6, pytest-8.2.0, pluggy-1.5.0
rootdir: /Users/jeestrad/Documents/Python/pre-upgrade/ACI-Pre-Upgrade-Validation-Script/ACI-Pre-Upgrade-Validation-Script
configfile: pytest.ini
collected 2 items

tests/leaf_to_spine_redundancy_check/test_leaf_to_spine_redundancy_check.py::test_logic[icurl_outputs0-FAIL - OUTAGE WARNING!!] PASSED [ 50%]
tests/leaf_to_spine_redundancy_check/test_leaf_to_spine_redundancy_check.py::test_logic[icurl_outputs1-PASS] PASSED [100%]

=========================================================================== 2 passed in 0.01s ============================================================================

4 Were you able to run integration test against the lab fabrics? [DONE]
Output from Lab Fabric with Tier2 Leaf Switches.

[Check 15/68] Leaf to Spine Redundancy check... FAIL - OUTAGE WARNING!!
Leaf Spine Message


d-leaf1 d-spine1 The Leaf Switch is connected to a Single Spine
d-leaf2 d-spine1 The Leaf Switch is connected to a Single Spine
d-leaf3 d-spine1 The Leaf Switch is connected to a Single Spine
d-leaf4 d-spine1 The Leaf Switch is connected to a Single Spine

Recommended Action: Connect the Leaf Switch(es) to multiple Spines for Redundancy

5 Documentation updates are missing [DONE]

Added documentation for general check 17 [g17]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NewValidation: Check if we have multiple spines in the lldp neighborship for the leaf
2 participants