-
Notifications
You must be signed in to change notification settings - Fork 27
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
New validation to address CSCwj69435 for the afected versions (#96)
* address CSCwj69435 for the afected versions * new logic for validation, test and documents added but not completed * new logic for validation, test and documents completed * new logic for validation, test and documents completed - small change * new logic for validation, test and documents completed - small change * Update aci-preupgrade-validation-script.py change doc_url Co-authored-by: takishida <[email protected]> * Update docs/docs/validations.md change white_check_mark to no_entry_sign Co-authored-by: takishida <[email protected]> * Update docs/docs/validations.md match the section title with the name in the summary table. Co-authored-by: takishida <[email protected]> * This codeblock needs indentations with 4 spaces to be inside the example note. * add 'else' to handle a case when the regex is not matching * moving this new validation up to right beneath [L2 Port Config][f8] * fix native-or-untagged-encap-failure and a minor allignment for [f9] * minor fix of the docs --------- Co-authored-by: takishida <[email protected]>
- Loading branch information
Showing
5 changed files
with
280 additions
and
15 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| [] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,147 @@ | ||
| [ | ||
| { | ||
| "faultInst": { | ||
| "attributes": { | ||
| "status": "", | ||
| "domain": "tenant", | ||
| "code": "F0467", | ||
| "occur": "1", | ||
| "subject": "management", | ||
| "severity": "minor", | ||
| "descr": "Configuration failed for uni/tn-EEA-1/ap-APP1/epg-EPG-2 node 102 Common-VPC-L101-102-To-N3K1-E35 due to Only One Native or Untagged Encap Allowed on Interface, debug message: ", | ||
| "title": "", | ||
| "origSeverity": "minor", | ||
| "childAction": "", | ||
| "cause": "configuration-failed", | ||
| "dn": "topology/pod-1/node-102/local/svc-policyelem-id-0/uni/epp/fv-[uni/tn-EEA-1/ap-APP1/epg-EPG-2]/node-102/stpathatt-[Common-VPC-L101-102-To-N3K1-E35]/nwissues/fault-F0467", | ||
| "prevSeverity": "minor", | ||
| "highestSeverity": "minor", | ||
| "alert": "no", | ||
| "delegated": "yes", | ||
| "lc": "raised", | ||
| "changeSet": "configQual:native-or-untagged-encap-failure, configSt:failed-to-apply, temporaryError:no", | ||
| "created": "2024-04-20T13:53:48.318+02:00", | ||
| "ack": "no", | ||
| "type": "config", | ||
| "rule": "fv-nw-issues-config-failed", | ||
| "lastTransition": "2024-04-20T13:54:10.743+02:00" | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "faultInst": { | ||
| "attributes": { | ||
| "status": "", | ||
| "domain": "tenant", | ||
| "code": "F0467", | ||
| "occur": "1", | ||
| "subject": "management", | ||
| "severity": "minor", | ||
| "descr": "Configuration failed for uni/tn-EEA-1/ap-APP1/epg-EPG-2 node 103 Common-VPC-103-104-To-SRV73-LACP due to Only One Native or Untagged Encap Allowed on Interface, debug message: ", | ||
| "title": "", | ||
| "origSeverity": "minor", | ||
| "childAction": "", | ||
| "cause": "configuration-failed", | ||
| "dn": "topology/pod-1/node-103/local/svc-policyelem-id-0/uni/epp/fv-[uni/tn-EEA-1/ap-APP1/epg-EPG-2]/node-103/stpathatt-[Common-VPC-103-104-To-SRV73-LACP]/nwissues/fault-F0467", | ||
| "prevSeverity": "minor", | ||
| "highestSeverity": "minor", | ||
| "alert": "no", | ||
| "delegated": "yes", | ||
| "lc": "raised", | ||
| "changeSet": "configQual:native-or-untagged-encap-failure, configSt:failed-to-apply, temporaryError:no", | ||
| "created": "2024-04-20T13:54:15.129+02:00", | ||
| "ack": "no", | ||
| "type": "config", | ||
| "rule": "fv-nw-issues-config-failed", | ||
| "lastTransition": "2024-04-20T13:54:41.861+02:00" | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "faultInst": { | ||
| "attributes": { | ||
| "status": "", | ||
| "domain": "tenant", | ||
| "code": "F0467", | ||
| "occur": "1", | ||
| "subject": "management", | ||
| "severity": "minor", | ||
| "descr": "Configuration failed for uni/tn-EEA-1/ap-APP1/epg-EPG-3 node 101 eth1/28 due to Only One Native or Untagged Encap Allowed on Interface, debug message: ", | ||
| "title": "", | ||
| "origSeverity": "minor", | ||
| "childAction": "", | ||
| "cause": "configuration-failed", | ||
| "dn": "topology/pod-1/node-101/local/svc-policyelem-id-0/uni/epp/fv-[uni/tn-EEA-1/ap-APP1/epg-EPG-3]/node-101/stpathatt-[eth1/28]/nwissues/fault-F0467", | ||
| "prevSeverity": "minor", | ||
| "highestSeverity": "minor", | ||
| "alert": "no", | ||
| "delegated": "yes", | ||
| "lc": "raised", | ||
| "changeSet": "configQual:native-or-untagged-encap-failure, configSt:failed-to-apply, temporaryError:no", | ||
| "created": "2024-04-20T10:57:54.056+02:00", | ||
| "ack": "no", | ||
| "type": "config", | ||
| "rule": "fv-nw-issues-config-failed", | ||
| "lastTransition": "2024-04-20T10:58:23.520+02:00" | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "faultInst": { | ||
| "attributes": { | ||
| "status": "", | ||
| "domain": "tenant", | ||
| "code": "F0467", | ||
| "occur": "1", | ||
| "subject": "management", | ||
| "severity": "minor", | ||
| "descr": "Configuration failed for uni/tn-EEA-1/ap-APP1/epg-EPG-2 node 101 eth1/28 due to Only One Native or Untagged Encap Allowed on Interface, debug message: ", | ||
| "title": "", | ||
| "origSeverity": "minor", | ||
| "childAction": "", | ||
| "cause": "configuration-failed", | ||
| "dn": "topology/pod-1/node-101/local/svc-policyelem-id-0/uni/epp/fv-[uni/tn-EEA-1/ap-APP1/epg-EPG-2]/node-101/stpathatt-[eth1/28]/nwissues/fault-F0467", | ||
| "prevSeverity": "minor", | ||
| "highestSeverity": "minor", | ||
| "alert": "no", | ||
| "delegated": "yes", | ||
| "lc": "raised", | ||
| "changeSet": "configQual:native-or-untagged-encap-failure, configSt:failed-to-apply, temporaryError:no", | ||
| "created": "2024-04-20T10:03:48.493+02:00", | ||
| "ack": "no", | ||
| "type": "config", | ||
| "rule": "fv-nw-issues-config-failed", | ||
| "lastTransition": "2024-04-20T10:03:53.045+02:00" | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "faultInst": { | ||
| "attributes": { | ||
| "status": "", | ||
| "domain": "tenant", | ||
| "code": "F0467", | ||
| "occur": "1", | ||
| "subject": "management", | ||
| "severity": "minor", | ||
| "descr": "Configuration failed for uni/tn-EEA-1/ap-APP1/epg-EPG-2 node 104 Common-VPC-103-104-To-SRV73-LACP due to Only One Native or Untagged Encap Allowed on Interface, debug message: ", | ||
| "title": "", | ||
| "origSeverity": "minor", | ||
| "childAction": "", | ||
| "cause": "configuration-failed", | ||
| "dn": "topology/pod-1/node-104/local/svc-policyelem-id-0/uni/epp/fv-[uni/tn-EEA-1/ap-APP1/epg-EPG-2]/node-104/stpathatt-[Common-VPC-103-104-To-SRV73-LACP]/nwissues/fault-F0467", | ||
| "prevSeverity": "minor", | ||
| "highestSeverity": "minor", | ||
| "alert": "no", | ||
| "delegated": "yes", | ||
| "lc": "raised", | ||
| "changeSet": "configQual:native-or-untagged-encap-failure, configSt:failed-to-apply, temporaryError:no", | ||
| "created": "2024-04-20T13:54:05.767+02:00", | ||
| "ack": "no", | ||
| "type": "config", | ||
| "rule": "fv-nw-issues-config-failed", | ||
| "lastTransition": "2024-04-20T13:54:13.497+02:00" | ||
| } | ||
| } | ||
| } | ||
| ] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| import os | ||
| import pytest | ||
| import logging | ||
| import importlib | ||
| from helpers.utils import read_data | ||
|
|
||
| script = importlib.import_module("aci-preupgrade-validation-script") | ||
|
|
||
| log = logging.getLogger(__name__) | ||
| dir = os.path.dirname(os.path.abspath(__file__)) | ||
|
|
||
|
|
||
| # icurl queries | ||
| faultInsts = 'faultInst.json?&query-target-filter=wcard(faultInst.changeSet,"native-or-untagged-encap-failure")' | ||
|
|
||
|
|
||
| @pytest.mark.parametrize( | ||
| "icurl_outputs, expected_result", | ||
| [ | ||
| ( | ||
| {faultInsts: read_data(dir, "faultInst_POS.json")}, | ||
| script.FAIL_O, | ||
| ), | ||
| ( | ||
| {faultInsts: read_data(dir, "faultInst_NEG.json")}, | ||
| script.PASS, | ||
| ) | ||
| ], | ||
| ) | ||
| def test_logic(mock_icurl,expected_result): | ||
| result = script.access_untagged_check(1, 1) | ||
| assert result == expected_result |