Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add consistency to comparison operators list #590

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

maneesha
Copy link
Contributor

In the interest of better readability, this PR adds consistency to the comparison operators list by:

  • Putting < and > on their own lines just as <= and >= are on their own lines
  • Adding colon at each definition (only some terms had this colon)

Add consistency to the comparison operators list by:
* Putting `<` and `>` on their own lines just as `<=` and `>=` are on their own lines
* Adding colon at each definition (only some terms had this colon)
Copy link

github-actions bot commented Feb 21, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/datacarpentry/python-ecology-lesson/compare/md-outputs..md-outputs-PR-590

The following changes were observed in the rendered markdown documents:

 03-index-slice-subset.md | 7 ++++---
 md5sum.txt               | 2 +-
 2 files changed, 5 insertions(+), 4 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-02-21 15:09:01 +0000

github-actions bot pushed a commit that referenced this pull request Feb 21, 2024
Copy link
Contributor

@quist00 quist00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The greater consistency is a nice improvement.

@quist00 quist00 merged commit e4826ed into main Feb 21, 2024
3 checks passed
@quist00 quist00 deleted the fix-comparison-operator-list branch February 21, 2024 16:42
github-actions bot pushed a commit that referenced this pull request Feb 21, 2024
Auto-generated via {sandpaper}
Source  : e4826ed
Branch  : main
Author  : David Palmquist <[email protected]>
Time    : 2024-02-21 16:42:27 +0000
Message : Merge pull request #590 from datacarpentry/fix-comparison-operator-list

Add consistency to comparison operators list
github-actions bot pushed a commit that referenced this pull request Feb 21, 2024
Auto-generated via {sandpaper}
Source  : 221e71b
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-02-21 16:43:20 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : e4826ed
Branch  : main
Author  : David Palmquist <[email protected]>
Time    : 2024-02-21 16:42:27 +0000
Message : Merge pull request #590 from datacarpentry/fix-comparison-operator-list

Add consistency to comparison operators list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants