Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addressing issues in mega issue section: R basics continued - factors and data frames #290

Merged
merged 5 commits into from
Oct 3, 2024

Conversation

ytakemon
Copy link
Contributor

@ytakemon ytakemon commented Oct 2, 2024

Addresses issue #285

  • Added text to explain what integers are and how they differ from numerics

Addresses issue #284

  • Breaks down code into a step-wise process to help review indexing from the previous section.

Addresses issue #283

  • Shows str(snps) is a character vector and that R does not intuitively know how to plot them and compares them to str(factor_snps).

@ytakemon ytakemon requested a review from naupaka October 2, 2024 16:18
Copy link

github-actions bot commented Oct 2, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/datacarpentry/genomics-r-intro/compare/md-outputs..md-outputs-PR-290

The following changes were observed in the rendered markdown documents:

 03-basics-factors-dataframes.md                    | 172 +++++++++++++++++++--
 ...ataframes-rendered-unnamed-chunk-13-1.png (new) | Bin 0 -> 362 bytes
 ...tors-dataframes-rendered-unnamed-chunk-18-1.png | Bin 3688 -> 3685 bytes
 ...ataframes-rendered-unnamed-chunk-20-1.png (new) | Bin 0 -> 3688 bytes
 md5sum.txt                                         |   2 +-
 5 files changed, 156 insertions(+), 18 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-10-02 16:38:56 +0000

github-actions bot pushed a commit that referenced this pull request Oct 2, 2024
@ytakemon
Copy link
Contributor Author

ytakemon commented Oct 2, 2024

Addresses issue #291

  • added more explanation for how to subset a 2D data frame

Addresses issue #292

  • making sure the text matches what the code is doing.

github-actions bot pushed a commit that referenced this pull request Oct 2, 2024
@ytakemon
Copy link
Contributor Author

ytakemon commented Oct 2, 2024

This should address the rest of the issues in this section. Ready to merge when you are @JasonJWilliamsNY and @naupaka !

Copy link
Member

@naupaka naupaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done @ytakemon -- LGTM

@naupaka naupaka merged commit 3c1641f into datacarpentry:main Oct 3, 2024
3 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 3, 2024
Auto-generated via {sandpaper}
Source  : 3c1641f
Branch  : main
Author  : Naupaka Zimmerman <[email protected]>
Time    : 2024-10-03 18:11:29 +0000
Message : Merge pull request #290 from ytakemon/iss_YT

Addressing issues in mega issue section: R basics continued - factors and data frames
github-actions bot pushed a commit that referenced this pull request Oct 3, 2024
Auto-generated via {sandpaper}
Source  : ed0608d
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-10-03 18:12:44 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 3c1641f
Branch  : main
Author  : Naupaka Zimmerman <[email protected]>
Time    : 2024-10-03 18:11:29 +0000
Message : Merge pull request #290 from ytakemon/iss_YT

Addressing issues in mega issue section: R basics continued - factors and data frames
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants