[CHORE] Moving QueryLinter input objects to signature
#3250
+62
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JCZuurmond
had a problem deploying
to
account-admin
GitHub Actions
Failure
|
❌ 89/90 passed, 1 flaky, 1 failed, 4 skipped, 1h15m44s total ❌ test_linter_from_context: TypeError: WorkflowLinter.refresh_report() missing 2 required positional arguments: 'sql_backend' and 'inventory_database' (6.912s)Flaky tests:
Running from acceptance #7423 |
JCZuurmond
changed the title
QueryLinter input objects to signatureQueryLinter input objects to signature
5 tasks
nfx
approved these changes
Nov 18, 2024
| TableMigrationIndex([]), | ||
| simple_ctx.directfs_access_crawler_for_queries, | ||
| simple_ctx.used_tables_crawler_for_queries, | ||
| None, | ||
| ) | ||
| linter.refresh_report(sql_backend, simple_ctx.inventory_database) | ||
| linter.refresh_report() |
There was a problem hiding this comment.
proper change here would be simple_ctx.query_linter.refresh_report()
JCZuurmond
force-pushed
the
fix/move-query-linter-objects-to-signature
branch
from
374f199
to
ba8bcdc
Compare
JCZuurmond
had a problem deploying
to
account-admin
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Follow the more common pattern of expect objects in a class signature. Those objects are passed on from the context. Makes testing more straightforward
Breaking down the linked PR below.
Linked issues
Progresses #3045
Breaks up #3112
Tests