Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Exporter] Improve exporting of databricks_pipeline resources #4142

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

alexott
Copy link
Contributor

@alexott alexott commented Oct 23, 2024

Changes

Changes include:

  • Use List + iterator instead of waiting for full list - improves performance in big workspaces with a lot of DLT pipelines
  • Better handling of pipelines deployed via DABs - fix error that lead to emitting of notebooks even for DLT pipelines deployed with DABs.
  • Emit databricks_schema for pipelines with direct publishing mode enabled.

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • relevant acceptance tests are passing
  • using Go SDK

Changes include:

- Use `List` + iterator instead of waiting for full list - improves performance in big
  workspaces with a lot of DLT pipelines
- Better handling of pipelines deployed via DABs - fix error that lead to emitting of
  notebooks even for DLT pipelines deployed with DABs.
- Emit `databricks_schema` for pipelines with direct publishing mode enabled.
@alexott alexott requested review from a team as code owners October 23, 2024 10:47
@alexott alexott requested review from renaudhartert-db and removed request for a team October 23, 2024 10:47
Copy link
Contributor

@renaudhartert-db renaudhartert-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexott alexott added this pull request to the merge queue Oct 24, 2024
Merged via the queue into main with commit 8b00572 Oct 24, 2024
7 checks passed
@alexott alexott deleted the exporter/improve-dlt-pipelines branch October 24, 2024 10:21
mgyucht added a commit that referenced this pull request Oct 28, 2024
### Bug Fixes

 * Recreate missing system schema  ([#4068](#4068)).
 * Tolerate `databricks_permissions` resources for SQL warehouses with `/warehouses/...` IDs ([#4158](#4158)).

### Documentation

 * Fix `databricks_grant` regarding metastore_id description ([#4164](#4164)).

### Internal Changes

 * Automatically trigger integration tests on PR ([#4149](#4149)).

### Exporter

 * **Breaking change** Use new query and alert resources instead of legacy resources ([#4150](#4150)).
 * Improve exporting of `databricks_pipeline` resources ([#4142](#4142)).
 * Improving reliability of `Emit` function ([#4163](#4163)).
mgyucht added a commit that referenced this pull request Oct 28, 2024
### Bug Fixes

 * Recreate missing system schema  ([#4068](#4068)).
 * Tolerate `databricks_permissions` resources for SQL warehouses with `/warehouses/...` IDs ([#4158](#4158)).

### Documentation

 * Fix `databricks_grant` regarding metastore_id description ([#4164](#4164)).

### Internal Changes

 * Automatically trigger integration tests on PR ([#4149](#4149)).

### Exporter

 * **Breaking change** Use new query and alert resources instead of legacy resources ([#4150](#4150)).
 * Improve exporting of `databricks_pipeline` resources ([#4142](#4142)).
 * Improving reliability of `Emit` function ([#4163](#4163)).
github-merge-queue bot pushed a commit that referenced this pull request Oct 28, 2024
### Bug Fixes

* Recreate missing system schema
([#4068](#4068)).
* Tolerate `databricks_permissions` resources for SQL warehouses with
`/warehouses/...` IDs
([#4158](#4158)).


### Documentation

* Fix `databricks_grant` regarding metastore_id description
([#4164](#4164)).


### Internal Changes

* Automatically trigger integration tests on PR
([#4149](#4149)).


### Exporter

* **Breaking change** Use new query and alert resources instead of
legacy resources
([#4150](#4150)).
* Improve exporting of `databricks_pipeline` resources
([#4142](#4142)).
* Improving reliability of `Emit` function
([#4163](#4163)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants