Providing testing capabilities to outside packages #373
+10
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The testing methods used inside
spark-redshift
are unfortunately all marked private and can't be used from the outside. We were looking for a way to run our tests against local mocks instead of the real online services. We got it working but had to do few minor adjustments tospark-redshift
. Let me know if we could integrate these into the official version.Our changes are:
spark-redshift
, so we added an extra constructor toDefaultSource
. The current constructor also requires aJDBCWrapper
, which is marked private and therefore doesn't seem to be able to be passed in from the outside.Let me know what you think and if this could be merged in.