-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Files API client: recover on download failures (#844) #845
Merged
renaudhartert-db
merged 5 commits into
databricks:main
from
ksafonov-db:files-api-recover-on-download-failures
Jan 8, 2025
Merged
[Feature] Files API client: recover on download failures (#844) #845
renaudhartert-db
merged 5 commits into
databricks:main
from
ksafonov-db:files-api-recover-on-download-failures
Jan 8, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksafonov-db
temporarily deployed
to
test-trigger-is
December 30, 2024 23:17 — with
GitHub Actions
Inactive
ksafonov-db
temporarily deployed
to
test-trigger-is
December 30, 2024 23:40 — with
GitHub Actions
Inactive
ksafonov-db
temporarily deployed
to
test-trigger-is
December 30, 2024 23:58 — with
GitHub Actions
Inactive
ksafonov-db
temporarily deployed
to
test-trigger-is
December 31, 2024 00:06 — with
GitHub Actions
Inactive
renaudhartert-db
changed the title
Files API client: recover on download failures (#844)
[Feature] Files API client: recover on download failures (#844)
Jan 2, 2025
Test Details: go/deco-tests/12582804714 |
renaudhartert-db
approved these changes
Jan 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ksafonov-db
force-pushed
the
files-api-recover-on-download-failures
branch
from
January 8, 2025 13:31
644ec16
to
0ec5120
Compare
ksafonov-db
temporarily deployed
to
test-trigger-is
January 8, 2025 13:32 — with
GitHub Actions
Inactive
ksafonov-db
force-pushed
the
files-api-recover-on-download-failures
branch
from
January 8, 2025 14:07
0ec5120
to
7b8116f
Compare
ksafonov-db
temporarily deployed
to
test-trigger-is
January 8, 2025 14:08 — with
GitHub Actions
Inactive
Signed-off-by: Kirill Safonov <[email protected]>
Signed-off-by: Kirill Safonov <[email protected]>
Signed-off-by: Kirill Safonov <[email protected]>
Signed-off-by: Kirill Safonov <[email protected]>
ksafonov-db
force-pushed
the
files-api-recover-on-download-failures
branch
from
January 8, 2025 14:23
7b8116f
to
66c8ca6
Compare
ksafonov-db
temporarily deployed
to
test-trigger-is
January 8, 2025 14:24 — with
GitHub Actions
Inactive
ksafonov-db
force-pushed
the
files-api-recover-on-download-failures
branch
from
January 8, 2025 14:24
66c8ca6
to
c7e8885
Compare
ksafonov-db
temporarily deployed
to
test-trigger-is
January 8, 2025 14:25 — with
GitHub Actions
Inactive
ksafonov-db
force-pushed
the
files-api-recover-on-download-failures
branch
from
January 8, 2025 14:26
c7e8885
to
66c8ca6
Compare
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
ksafonov-db
temporarily deployed
to
test-trigger-is
January 8, 2025 14:27 — with
GitHub Actions
Inactive
renaudhartert-db
added a commit
that referenced
this pull request
Jan 20, 2025
### New Features and Improvements * Add `serving.http_request` to call external functions. ([#857](#857)). * Files API client: recover on download failures ([#844](#844)) ([#845](#845)). ### Bug Fixes * Properly pass query parameters in apps and oauth2 ([#862](#862)). ### Internal Changes * Add unit tests for external-browser authentication ([#863](#863)). * Decouple oauth2 and serving ([#855](#855)). * Migrate workflows that need write access to use hosted runners ([#850](#850)). * Stop testing Python 3.7 on Ubuntu ([#858](#858)). ### API Changes: * Added [w.access_control](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/access_control.html) workspace-level service. * Added `http_request()` method for [w.serving_endpoints](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/serving_endpoints.html) workspace-level service. * Added `no_compute` field for `databricks.sdk.service.apps.CreateAppRequest`. * Added `has_more` field for `databricks.sdk.service.jobs.BaseJob`. * Added `has_more` field for `databricks.sdk.service.jobs.BaseRun`. * Added `page_token` field for `databricks.sdk.service.jobs.GetJobRequest`. * Added `has_more` and `next_page_token` fields for `databricks.sdk.service.jobs.Job`. * Added `has_more` field for `databricks.sdk.service.jobs.Run`. * Added `clean_rooms_notebook_output` field for `databricks.sdk.service.jobs.RunOutput`. * Added `scopes` field for `databricks.sdk.service.oauth2.UpdateCustomAppIntegration`. * Added `run_as` field for `databricks.sdk.service.pipelines.CreatePipeline`. * Added `run_as` field for `databricks.sdk.service.pipelines.EditPipeline`. * Added `authorization_details` and `endpoint_url` fields for `databricks.sdk.service.serving.DataPlaneInfo`. * Added `contents` field for `databricks.sdk.service.serving.GetOpenApiResponse`. * Added `activated`, `activation_url`, `authentication_type`, `cloud`, `comment`, `created_at`, `created_by`, `data_recipient_global_metastore_id`, `ip_access_list`, `metastore_id`, `name`, `owner`, `properties_kvpairs`, `region`, `sharing_code`, `tokens`, `updated_at` and `updated_by` fields for `databricks.sdk.service.sharing.RecipientInfo`. * Added `expiration_time` field for `databricks.sdk.service.sharing.RecipientInfo`. * Added . * Added . * Added , , and . * Added . * Added , , , and . * Changed `update()` method for [a.account_federation_policy](https://databricks-sdk-py.readthedocs.io/en/latest/account/account_federation_policy.html) account-level service with new required argument order. * Changed `update()` method for [a.service_principal_federation_policy](https://databricks-sdk-py.readthedocs.io/en/latest/account/service_principal_federation_policy.html) account-level service with new required argument order. * Changed `update()` method for [w.recipients](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/recipients.html) workspace-level service to return `databricks.sdk.service.sharing.RecipientInfo` dataclass. * Changed `update()` method for [w.recipients](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/recipients.html) workspace-level service return type to become non-empty. * Changed `update()` method for [w.recipients](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/recipients.html) workspace-level service to type `update()` method for [w.recipients](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/recipients.html) workspace-level service. * Changed `get_open_api()` method for [w.serving_endpoints](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/serving_endpoints.html) workspace-level service return type to become non-empty. * Changed `patch()` method for [w.serving_endpoints](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/serving_endpoints.html) workspace-level service to type `patch()` method for [w.serving_endpoints](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/serving_endpoints.html) workspace-level service. * Changed `patch()` method for [w.serving_endpoints](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/serving_endpoints.html) workspace-level service to return `databricks.sdk.service.serving.EndpointTags` dataclass. * Changed `databricks.sdk.service.serving.EndpointTagList` dataclass to. * Changed `collaborator_alias` field for `databricks.sdk.service.cleanrooms.CleanRoomCollaborator` to be required. * Changed `collaborator_alias` field for `databricks.sdk.service.cleanrooms.CleanRoomCollaborator` to be required. * Changed `update_mask` field for `databricks.sdk.service.oauth2.UpdateAccountFederationPolicyRequest` to no longer be required. * Changed `update_mask` field for `databricks.sdk.service.oauth2.UpdateServicePrincipalFederationPolicyRequest` to no longer be required. * Changed `days_of_week` field for `databricks.sdk.service.pipelines.RestartWindow` to type `databricks.sdk.service.pipelines.DayOfWeekList` dataclass. * Changed `behavior` field for `databricks.sdk.service.serving.AiGatewayGuardrailPiiBehavior` to no longer be required. * Changed `behavior` field for `databricks.sdk.service.serving.AiGatewayGuardrailPiiBehavior` to no longer be required. * Changed `project_id` and `region` fields for `databricks.sdk.service.serving.GoogleCloudVertexAiConfig` to be required. * Changed `project_id` and `region` fields for `databricks.sdk.service.serving.GoogleCloudVertexAiConfig` to be required. * Changed `workload_type` field for `databricks.sdk.service.serving.ServedEntityInput` to type `databricks.sdk.service.serving.ServingModelWorkloadType` dataclass. * Changed `workload_type` field for `databricks.sdk.service.serving.ServedEntityOutput` to type `databricks.sdk.service.serving.ServingModelWorkloadType` dataclass. * Changed `workload_type` field for `databricks.sdk.service.serving.ServedModelOutput` to type `databricks.sdk.service.serving.ServingModelWorkloadType` dataclass. * Changed . * Changed . OpenAPI SHA: 58905570a9928fc9ed31fba14a2edaf9a7c55b08, Date: 2025-01-20
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 20, 2025
### New Features and Improvements * Add `serving.http_request` to call external functions. ([#857](#857)). * Files API client: recover on download failures ([#844](#844)) ([#845](#845)). ### Bug Fixes * Properly pass query parameters in apps and oauth2 ([#862](#862)). ### Internal Changes * Add unit tests for external-browser authentication ([#863](#863)). * Decouple oauth2 and serving ([#855](#855)). * Migrate workflows that need write access to use hosted runners ([#850](#850)). * Stop testing Python 3.7 on Ubuntu ([#858](#858)). ### API Changes: * Added [w.access_control](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/access_control.html) workspace-level service. * Added `http_request()` method for [w.serving_endpoints](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/serving_endpoints.html) workspace-level service. * Added `no_compute` field for `databricks.sdk.service.apps.CreateAppRequest`. * Added `has_more` field for `databricks.sdk.service.jobs.BaseJob`. * Added `has_more` field for `databricks.sdk.service.jobs.BaseRun`. * Added `page_token` field for `databricks.sdk.service.jobs.GetJobRequest`. * Added `has_more` and `next_page_token` fields for `databricks.sdk.service.jobs.Job`. * Added `has_more` field for `databricks.sdk.service.jobs.Run`. * Added `clean_rooms_notebook_output` field for `databricks.sdk.service.jobs.RunOutput`. * Added `scopes` field for `databricks.sdk.service.oauth2.UpdateCustomAppIntegration`. * Added `run_as` field for `databricks.sdk.service.pipelines.CreatePipeline`. * Added `run_as` field for `databricks.sdk.service.pipelines.EditPipeline`. * Added `authorization_details` and `endpoint_url` fields for `databricks.sdk.service.serving.DataPlaneInfo`. * Added `contents` field for `databricks.sdk.service.serving.GetOpenApiResponse`. * Added `activated`, `activation_url`, `authentication_type`, `cloud`, `comment`, `created_at`, `created_by`, `data_recipient_global_metastore_id`, `ip_access_list`, `metastore_id`, `name`, `owner`, `properties_kvpairs`, `region`, `sharing_code`, `tokens`, `updated_at` and `updated_by` fields for `databricks.sdk.service.sharing.RecipientInfo`. * Added `expiration_time` field for `databricks.sdk.service.sharing.RecipientInfo`. * Changed `update()` method for [a.account_federation_policy](https://databricks-sdk-py.readthedocs.io/en/latest/account/account_federation_policy.html) account-level service with new required argument order. * Changed `update()` method for [a.service_principal_federation_policy](https://databricks-sdk-py.readthedocs.io/en/latest/account/service_principal_federation_policy.html) account-level service with new required argument order. * Changed `update()` method for [w.recipients](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/recipients.html) workspace-level service to return `databricks.sdk.service.sharing.RecipientInfo` dataclass. * Changed `update()` method for [w.recipients](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/recipients.html) workspace-level service return type to become non-empty. * Changed `update()` method for [w.recipients](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/recipients.html) workspace-level service to type `update()` method for [w.recipients](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/recipients.html) workspace-level service. * Changed `get_open_api()` method for [w.serving_endpoints](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/serving_endpoints.html) workspace-level service return type to become non-empty. * Changed `patch()` method for [w.serving_endpoints](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/serving_endpoints.html) workspace-level service to type `patch()` method for [w.serving_endpoints](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/serving_endpoints.html) workspace-level service. * Changed `patch()` method for [w.serving_endpoints](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/serving_endpoints.html) workspace-level service to return `databricks.sdk.service.serving.EndpointTags` dataclass. * Changed `databricks.sdk.service.serving.EndpointTagList` dataclass to. * Changed `collaborator_alias` field for `databricks.sdk.service.cleanrooms.CleanRoomCollaborator` to be required. * Changed `collaborator_alias` field for `databricks.sdk.service.cleanrooms.CleanRoomCollaborator` to be required. * Changed `update_mask` field for `databricks.sdk.service.oauth2.UpdateAccountFederationPolicyRequest` to no longer be required. * Changed `update_mask` field for `databricks.sdk.service.oauth2.UpdateServicePrincipalFederationPolicyRequest` to no longer be required. * Changed `days_of_week` field for `databricks.sdk.service.pipelines.RestartWindow` to type `databricks.sdk.service.pipelines.DayOfWeekList` dataclass. * Changed `behavior` field for `databricks.sdk.service.serving.AiGatewayGuardrailPiiBehavior` to no longer be required. * Changed `behavior` field for `databricks.sdk.service.serving.AiGatewayGuardrailPiiBehavior` to no longer be required. * Changed `project_id` and `region` fields for `databricks.sdk.service.serving.GoogleCloudVertexAiConfig` to be required. * Changed `project_id` and `region` fields for `databricks.sdk.service.serving.GoogleCloudVertexAiConfig` to be required. * Changed `workload_type` field for `databricks.sdk.service.serving.ServedEntityInput` to type `databricks.sdk.service.serving.ServingModelWorkloadType` dataclass. * Changed `workload_type` field for `databricks.sdk.service.serving.ServedEntityOutput` to type `databricks.sdk.service.serving.ServingModelWorkloadType` dataclass. * Changed `workload_type` field for `databricks.sdk.service.serving.ServedModelOutput` to type `databricks.sdk.service.serving.ServingModelWorkloadType` dataclass. OpenAPI SHA: 58905570a9928fc9ed31fba14a2edaf9a7c55b08, Date: 2025-01-20 --------- Signed-off-by: Renaud Hartert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
How is this tested?
Added unit tests for the new code path:
% python3 -m pytest tests/test_files.py