Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable gofumpt in vscode #2001

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Enable gofumpt in vscode #2001

merged 1 commit into from
Dec 12, 2024

Conversation

denik
Copy link
Contributor

@denik denik commented Dec 12, 2024

Tests

Verified that with this setting, VSCode reformats code on Save according to gofumpt rules.

@denik denik temporarily deployed to test-trigger-is December 12, 2024 09:55 — with GitHub Actions Inactive
@denik denik requested a review from pietern December 12, 2024 09:55
Copy link

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/cli

Inputs:

  • PR number: 2001
  • Commit SHA: 3712e8e3062650386f987235efa7f7094dbf90bc

Checks will be approved automatically on success.

@denik denik requested a review from andrewnester December 12, 2024 09:56
@denik denik temporarily deployed to test-trigger-is December 12, 2024 09:56 — with GitHub Actions Inactive
@denik denik enabled auto-merge December 12, 2024 09:56
@eng-dev-ecosystem-bot
Copy link
Collaborator

Test Details: go/deco-tests/12293957509

Copy link
Contributor

@pietern pietern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a requirement for a particular gopls version to make this work?

@@ -7,6 +7,10 @@
"go.lintFlags": [
"--fast"
],
"go.useLanguageServer": true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the default, not needed AFAIK.

@denik
Copy link
Contributor Author

denik commented Dec 12, 2024

Is there a requirement for a particular gopls version to make this work?

It is supported since 2020, so should not be a concern golang/tools@62a0bb

@denik denik disabled auto-merge December 12, 2024 10:06
@denik denik merged commit a7e91a5 into main Dec 12, 2024
10 checks passed
@denik denik deleted the denis.bilenko/gofumpt-vscode branch December 12, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants