Fixed adding /Workspace prefix for resource paths #1866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
pietern
reviewed
Oct 30, 2024
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
commented
Oct 30, 2024
| @@ -67,6 +68,11 @@ func giveAccessForWorkspaceRoot(ctx context.Context, b *bundle.Bundle) error { | |||
| } | |||
|
|
|||
| func setPermissions(ctx context.Context, w workspace.WorkspaceInterface, path string, permissions []workspace.WorkspaceObjectAccessControlRequest) error { | |||
| // If the folder is shared, then we don't need to set permissions since it's always set for all users and it's checked in mutators before. | |||
| if libraries.IsWorkspaceSharedPath(path) { | |||
There was a problem hiding this comment.
As per discussion here #1821 (comment)
|
Test Details: go/deco-tests/11598536835 |
pietern
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
/Workspaceprefix needs to be added toresource_pathas well.Fixes the issue mentioned here: #1822 (comment)
Fixes #1867
Tests
Added regression test