Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cmd-exec-id to user agent #1808

Merged
merged 9 commits into from
Nov 1, 2024
Merged
Show file tree
Hide file tree
Changes from 8 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cmd/root/root.go
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ func New(ctx context.Context) *cobra.Command {
// Configure our user agent with the command that's about to be executed.
ctx = withCommandInUserAgent(ctx, cmd)
ctx = withUpstreamInUserAgent(ctx)
ctx = withCommandExecIdInUserAgent(ctx)
shreyas-goenka marked this conversation as resolved.
Show resolved Hide resolved
cmd.SetContext(ctx)
return nil
}
Expand Down
16 changes: 16 additions & 0 deletions cmd/root/user_agent_command_exec_id.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
package root

import (
"context"

"github.com/databricks/databricks-sdk-go/useragent"
"github.com/google/uuid"
)

func withCommandExecIdInUserAgent(ctx context.Context) context.Context {
// A UUID that'll will allow use to correlate multiple API requests made by
// the same command invocation.
shreyas-goenka marked this conversation as resolved.
Show resolved Hide resolved
// When we add telemetry to the CLI, this exec ID will allow allow us to
// correlate logs in HTTP access logs with logs in Frontend logs.
shreyas-goenka marked this conversation as resolved.
Show resolved Hide resolved
return useragent.InContext(ctx, "cmd-exec-id", uuid.New().String())
}
26 changes: 26 additions & 0 deletions cmd/root/user_agent_command_exec_id_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
package root

import (
"context"
"regexp"
"testing"

"github.com/databricks/databricks-sdk-go/useragent"
"github.com/google/uuid"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)

func TestWithCommandExecIdInUserAgent(t *testing.T) {
ctx := withCommandExecIdInUserAgent(context.Background())

// Check that the command exec ID is in the user agent string.
ua := useragent.FromContext(ctx)
re := regexp.MustCompile(`cmd-exec-id/([a-f0-9-]+)`)
matches := re.FindAllStringSubmatch(ua, -1)

// Assert that we have exactly one match and that it's a valid UUID.
require.Len(t, matches, 1)
_, err := uuid.Parse(matches[0][1])
assert.NoError(t, err)
}
9 changes: 8 additions & 1 deletion cmd/root/user_agent_command_test.go
Original file line number Diff line number Diff line change
@@ -1,13 +1,15 @@
package root

import (
"context"
"testing"

"github.com/databricks/databricks-sdk-go/useragent"
"github.com/spf13/cobra"
"github.com/stretchr/testify/assert"
)

func TestCommandString(t *testing.T) {
func TestWithCommandInUserAgent(t *testing.T) {
root := &cobra.Command{
Use: "root",
}
Expand All @@ -26,4 +28,9 @@ func TestCommandString(t *testing.T) {
assert.Equal(t, "root", commandString(root))
assert.Equal(t, "hello", commandString(hello))
assert.Equal(t, "hello_world", commandString(world))

ctx := withCommandInUserAgent(context.Background(), world)

ua := useragent.FromContext(ctx)
assert.Contains(t, ua, "cmd/hello_world")
}
Loading