Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix non-default project names not working in dbt-sql template #1500

Merged
merged 3 commits into from
Jul 1, 2024
Merged

Fix non-default project names not working in dbt-sql template #1500

merged 3 commits into from
Jul 1, 2024

Conversation

kijewskimateusz
Copy link
Contributor

Changes

Hello Team,

While tinkering with your solution, I've noticed that profiles provided in dbt_project.yml and profiles.yml for generated dbt asset bundles. do not align. This led to the following error, when deploying DAB:

+ dbt deps --target=dev
11:24:02  Running with dbt=1.8.2
11:24:02  Warning: No packages were found in packages.yml
11:24:02  Warning: No packages were found in packages.yml

+ dbt seed --target=dev --vars '{ dev_schema: mateusz_kijewski }'
11:24:05  Running with dbt=1.8.2
11:24:05  Encountered an error:
Runtime Error
  Could not find profile named 'dbt_sql'

I have corrected profile name in profiles.yml.tmpl to the name used in dbt_project.yml.tmpl. Using the opportunity of forking your repo, I've also updated tests configuration in model config as starting of dbt v1.8 it's been raising warnings of configuration change from tests to data_tests

11:31:34  [WARNING]: Deprecated functionality
The `tests` config has been renamed to `data_tests`. Please see
https://docs.getdbt.com/docs/build/data-tests#new-data_tests-syntax for more
information.

Tests

@kijewskimateusz kijewskimateusz mentioned this pull request Jun 17, 2024
Closed
@lennartkats-db lennartkats-db self-requested a review June 17, 2024 19:29
@lennartkats-db
Copy link
Contributor

This is great @kijewskimateusz, thanks for your original report and your contribution!

I tested these changes and they work as expected.

@lennartkats-db lennartkats-db changed the title Fix Dbt profile name for asset bundle deployment Fix non-standard project names not working in dbt-sql template Jun 17, 2024
@lennartkats-db lennartkats-db changed the title Fix non-standard project names not working in dbt-sql template Fix non-default project names not working in dbt-sql template Jun 17, 2024
@pietern
Copy link
Contributor

pietern commented Jun 18, 2024

@kijewskimateusz Thanks for your contribution! We need a CLA to be signed for contributions to this repository. Could you send an email to [email protected] and include your name and then we can take it from there.

@pietern pietern linked an issue Jun 18, 2024 that may be closed by this pull request
Incorrect Dbt profile name for asset bundle template rendering #1501
Closed
@lennartkats-db lennartkats-db enabled auto-merge July 1, 2024 07:51
@lennartkats-db lennartkats-db added this pull request to the merge queue Jul 1, 2024
Merged via the queue into databricks:main with commit c7a3692 Jul 1, 2024
5 checks passed
pietern added a commit that referenced this pull request Jul 3, 2024
@pietern
Release v0.223.0
2d43db2 
Bundles:

As of this release you can interact with bundles when running the CLI on DBR (e.g. via the Web Terminal).

 * Fix non-default project names not working in dbt-sql template ([#1500](#1500)).
 * Improve `bundle validate` output ([#1532](#1532)).
 * Fixed resolving variable references inside slice variable ([#1550](#1550)).
 * Fixed bundle not loading when empty variable is defined ([#1552](#1552)).
 * Use `vfs.Path` for filesystem interaction ([#1554](#1554)).
 * Replace `vfs.Path` with extension-aware filer when running on DBR ([#1556](#1556)).

Internal:
 * merge.Override: Fix handling of dyn.NilValue ([#1530](#1530)).
 * Compare `.Kind()` instead of direct equality checks on a `dyn.Value` ([#1520](#1520)).
 * PythonMutator: register product in user agent extra ([#1533](#1533)).
 * Ignore `dyn.NilValue` when traversing value from `dyn.Map` ([#1547](#1547)).
 * Add extra tests for the sync block ([#1548](#1548)).
 * PythonMutator: add diagnostics ([#1531](#1531)).
 * PythonMutator: support omitempty in PyDABs ([#1513](#1513)).
 * PythonMutator: allow insert 'resources' and 'resources.jobs' ([#1555](#1555)).
@pietern pietern mentioned this pull request Jul 3, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jul 3, 2024
@pietern
Release v0.223.0 (#1557)
2a73d77 
Bundles:

As of this release you can interact with bundles when running the CLI on
DBR (e.g. via the Web Terminal).

* Fix non-default project names not working in dbt-sql template
([#1500](#1500)).
* Improve `bundle validate` output
([#1532](#1532)).
* Fixed resolving variable references inside slice variable
([#1550](#1550)).
* Fixed bundle not loading when empty variable is defined
([#1552](#1552)).
* Use `vfs.Path` for filesystem interaction
([#1554](#1554)).
* Replace `vfs.Path` with extension-aware filer when running on DBR
([#1556](#1556)).

Internal:
* merge.Override: Fix handling of dyn.NilValue
([#1530](#1530)).
* Compare `.Kind()` instead of direct equality checks on a `dyn.Value`
([#1520](#1520)).
* PythonMutator: register product in user agent extra
([#1533](#1533)).
* Ignore `dyn.NilValue` when traversing value from `dyn.Map`
([#1547](#1547)).
* Add extra tests for the sync block
([#1548](#1548)).
* PythonMutator: add diagnostics
([#1531](#1531)).
* PythonMutator: support omitempty in PyDABs
([#1513](#1513)).
* PythonMutator: allow insert 'resources' and 'resources.jobs'
([#1555](#1555)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lennartkats-db lennartkats-db lennartkats-db approved these changes

Assignees
No one assigned
Labels
cla-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect Dbt profile name for asset bundle template rendering
3 participants
@kijewskimateusz @lennartkats-db @pietern