Skip to content

Commit

Permalink
Update target references to use ${bundle.target} (#1935)
Browse files Browse the repository at this point in the history
## Changes

The built-in template contains a reference to `${bundle.environment}`.

This property has been deprecated in favor of `${bundle.target}` a long
time ago (#670), so we should no longer emit it. The environment field
will continue to be usable until we cut a new major version in some far
away future.

## Tests

* Unit tests
* The test `TestInterpolationWithTarget` still covers correct
interpolation of `${bundle.environment}`
  • Loading branch information
pietern authored Nov 27, 2024
1 parent 85c0d2d commit fae1b67
Show file tree
Hide file tree
Showing 8 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion bundle/tests/python_wheel/python_wheel/bundle.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ artifacts:
resources:
jobs:
test_job:
name: "[${bundle.environment}] My Wheel Job"
name: "[${bundle.target}] My Wheel Job"
tasks:
- task_key: TestTask
existing_cluster_id: "0717-132531-5opeqon1"
Expand Down
2 changes: 1 addition & 1 deletion bundle/tests/python_wheel/python_wheel_dbfs_lib/bundle.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ bundle:
resources:
jobs:
test_job:
name: "[${bundle.environment}] My Wheel Job"
name: "[${bundle.target}] My Wheel Job"
tasks:
- task_key: TestTask
existing_cluster_id: "0717-132531-5opeqon1"
Expand Down
2 changes: 1 addition & 1 deletion bundle/tests/python_wheel/python_wheel_multiple/bundle.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ artifacts:
resources:
jobs:
test_job:
name: "[${bundle.environment}] My Wheel Job"
name: "[${bundle.target}] My Wheel Job"
tasks:
- task_key: TestTask
existing_cluster_id: "0717-132531-5opeqon1"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ bundle:
resources:
jobs:
test_job:
name: "[${bundle.environment}] My Wheel Job"
name: "[${bundle.target}] My Wheel Job"
tasks:
- task_key: TestTask
existing_cluster_id: "0717-aaaaa-bbbbbb"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ workspace:
resources:
jobs:
test_job:
name: "[${bundle.environment}] My Wheel Job"
name: "[${bundle.target}] My Wheel Job"
tasks:
- task_key: TestTask
existing_cluster_id: "0717-aaaaa-bbbbbb"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ bundle:
resources:
jobs:
test_job:
name: "[${bundle.environment}] My Wheel Job"
name: "[${bundle.target}] My Wheel Job"
tasks:
- task_key: TestTask
existing_cluster_id: "0717-aaaaa-bbbbbb"
Expand Down
2 changes: 1 addition & 1 deletion bundle/tests/python_wheel/python_wheel_no_build/bundle.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ bundle:
resources:
jobs:
test_job:
name: "[${bundle.environment}] My Wheel Job"
name: "[${bundle.target}] My Wheel Job"
tasks:
- task_key: TestTask
existing_cluster_id: "0717-132531-5opeqon1"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ resources:
{{- else}}
catalog: {{default_catalog}}
{{- end}}
target: {{.project_name}}_${bundle.environment}
target: {{.project_name}}_${bundle.target}
libraries:
- notebook:
path: ../src/dlt_pipeline.ipynb
Expand Down

0 comments on commit fae1b67

Please sign in to comment.