Skip to content

Commit

Permalink
Added integration test to deploy bundle to /Shared root path (#1914)
Browse files Browse the repository at this point in the history
## Changes
Added integration test to deploy bundle to /Shared root path

## Tests
```
--- PASS: TestAccDeployBasicToSharedWorkspace (24.58s)
PASS
coverage: 31.2% of statements in ./...
ok  	github.com/databricks/cli/internal/bundle	25.572s	coverage: 31.2% of statements in ./...
```

---------

Co-authored-by: shreyas-goenka <[email protected]>
  • Loading branch information
andrewnester and shreyas-goenka authored Nov 20, 2024
1 parent 756e55f commit fab3e8f
Show file tree
Hide file tree
Showing 3 changed files with 47 additions and 0 deletions.
5 changes: 5 additions & 0 deletions internal/bundle/bundles/basic/databricks_template_schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,11 @@
"node_type_id": {
"type": "string",
"description": "Node type id for job cluster"
},
"root_path": {
"type": "string",
"description": "Root path to deploy bundle to",
"default": ""
}
}
}
4 changes: 4 additions & 0 deletions internal/bundle/bundles/basic/template/databricks.yml.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,11 @@ bundle:
name: basic

workspace:
{{ if .root_path }}
root_path: "{{.root_path}}/.bundle/{{.unique_id}}"
{{ else }}
root_path: "~/.bundle/{{.unique_id}}"
{{ end }}

resources:
jobs:
Expand Down
38 changes: 38 additions & 0 deletions internal/bundle/deploy_to_shared_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
package bundle

import (
"fmt"
"testing"

"github.com/databricks/cli/internal"
"github.com/databricks/cli/internal/acc"
"github.com/databricks/cli/libs/env"
"github.com/google/uuid"
"github.com/stretchr/testify/require"
)

func TestAccDeployBasicToSharedWorkspacePath(t *testing.T) {
ctx, wt := acc.WorkspaceTest(t)

nodeTypeId := internal.GetNodeTypeId(env.Get(ctx, "CLOUD_ENV"))
uniqueId := uuid.New().String()

currentUser, err := wt.W.CurrentUser.Me(ctx)
require.NoError(t, err)

bundleRoot, err := initTestTemplate(t, ctx, "basic", map[string]any{
"unique_id": uniqueId,
"node_type_id": nodeTypeId,
"spark_version": defaultSparkVersion,
"root_path": fmt.Sprintf("/Shared/%s", currentUser.UserName),
})
require.NoError(t, err)

t.Cleanup(func() {
err = destroyBundle(wt.T, ctx, bundleRoot)
require.NoError(wt.T, err)
})

err = deployBundle(wt.T, ctx, bundleRoot)
require.NoError(wt.T, err)
}

0 comments on commit fab3e8f

Please sign in to comment.