Skip to content

Commit

Permalink
Remove changes reversed to a future pull request
Browse files Browse the repository at this point in the history
  • Loading branch information
domcorvasce committed Dec 21, 2023
1 parent 52dd93a commit be84b9f
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 13 deletions.
12 changes: 0 additions & 12 deletions bundle/config/mutator/process_target_mode_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -179,18 +179,6 @@ func TestProcessTargetModeDevelopmentCustomResourceNamePrefix(t *testing.T) {
assert.Equal(t, "staging__us_east_1_registeredmodel1", b.Config.Resources.RegisteredModels["registeredmodel1"].Name)
}

func TestProcessTargetModeDevelopmentCustomDeploymentTag(t *testing.T) {
b := mockBundle(config.Development)
b.Config.Bundle.ResourceNamePrefix = "custom"

m := ProcessTargetMode()
err := bundle.Apply(context.Background(), b, m)
require.NoError(t, err)

// Job 1
assert.Equal(t, "[custom] job1", b.Config.Resources.Jobs["job1"].Name)
}

func TestProcessTargetModeDevelopmentTagNormalizationForAws(t *testing.T) {
b := mockBundle(config.Development)
b.Tagging = tags.ForCloud(&sdkconfig.Config{
Expand Down
2 changes: 1 addition & 1 deletion bundle/config/target.go
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ type Target struct {

const (
// Development mode: deployments done purely for running things in development.
// Any deployed resources will be marked as "dev" (or custom a `tag`) and might be hidden or cleaned up.
// Any deployed resources will be marked as "dev" and might be hidden or cleaned up.
Development Mode = "development"

// Production mode: deployments done for production purposes.
Expand Down

0 comments on commit be84b9f

Please sign in to comment.