-
Notifications
You must be signed in to change notification settings - Fork 57
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
5 changed files
with
143 additions
and
0 deletions.
There are no files selected for viewing
12 changes: 12 additions & 0 deletions
12
internal/bundle/bundles/dashboards/databricks_template_schema.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
{ | ||
"properties": { | ||
"unique_id": { | ||
"type": "string", | ||
"description": "Unique ID for job name" | ||
}, | ||
"warehouse_id": { | ||
"type": "string", | ||
"description": "The SQL warehouse ID to use for the dashboard" | ||
} | ||
} | ||
} |
34 changes: 34 additions & 0 deletions
34
internal/bundle/bundles/dashboards/template/dashboard.lvdash.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
{ | ||
"pages": [ | ||
{ | ||
"displayName": "New Page", | ||
"layout": [ | ||
{ | ||
"position": { | ||
"height": 2, | ||
"width": 6, | ||
"x": 0, | ||
"y": 0 | ||
}, | ||
"widget": { | ||
"name": "82eb9107", | ||
"textbox_spec": "# I'm a title" | ||
} | ||
}, | ||
{ | ||
"position": { | ||
"height": 2, | ||
"width": 6, | ||
"x": 0, | ||
"y": 2 | ||
}, | ||
"widget": { | ||
"name": "ffa6de4f", | ||
"textbox_spec": "Text" | ||
} | ||
} | ||
], | ||
"name": "fdd21a3c" | ||
} | ||
] | ||
} |
12 changes: 12 additions & 0 deletions
12
internal/bundle/bundles/dashboards/template/databricks.yml.tmpl
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
bundle: | ||
name: dashboards | ||
|
||
workspace: | ||
root_path: "~/.bundle/{{.unique_id}}" | ||
|
||
resources: | ||
dashboards: | ||
file_reference: | ||
display_name: test-dashboard-{{.unique_id}} | ||
file_path: ./dashboard.lvdash.json | ||
warehouse_id: {{.warehouse_id}} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,63 @@ | ||
package bundle | ||
|
||
import ( | ||
"fmt" | ||
"testing" | ||
|
||
"github.com/databricks/cli/internal/acc" | ||
"github.com/databricks/databricks-sdk-go/service/dashboards" | ||
"github.com/databricks/databricks-sdk-go/service/workspace" | ||
"github.com/google/uuid" | ||
"github.com/stretchr/testify/assert" | ||
"github.com/stretchr/testify/require" | ||
) | ||
|
||
func TestAccDashboards(t *testing.T) { | ||
ctx, wt := acc.WorkspaceTest(t) | ||
|
||
warehouseID := acc.GetEnvOrSkipTest(t, "TEST_DEFAULT_WAREHOUSE_ID") | ||
uniqueID := uuid.New().String() | ||
root, err := initTestTemplate(t, ctx, "dashboards", map[string]any{ | ||
"unique_id": uniqueID, | ||
"warehouse_id": warehouseID, | ||
}) | ||
require.NoError(t, err) | ||
|
||
t.Cleanup(func() { | ||
err = destroyBundle(t, ctx, root) | ||
require.NoError(t, err) | ||
}) | ||
|
||
err = deployBundle(t, ctx, root) | ||
require.NoError(t, err) | ||
|
||
// Load bundle configuration by running the validate command. | ||
b := unmarshalConfig(t, mustValidateBundle(t, ctx, root)) | ||
|
||
// Assert that the dashboard exists at the expected path and is, indeed, a dashboard. | ||
oi, err := wt.W.Workspace.GetStatusByPath(ctx, fmt.Sprintf("%s/test-dashboard-%s.lvdash.json", b.Config.Workspace.ResourcePath, uniqueID)) | ||
require.NoError(t, err) | ||
assert.EqualValues(t, workspace.ObjectTypeDashboard, oi.ObjectType) | ||
|
||
// Load the dashboard by its ID and confirm its display name. | ||
dashboard, err := wt.W.Lakeview.GetByDashboardId(ctx, oi.ResourceId) | ||
require.NoError(t, err) | ||
assert.Equal(t, fmt.Sprintf("test-dashboard-%s", uniqueID), dashboard.DisplayName) | ||
|
||
// Make an out of band modification to the dashboard and confirm that it is detected. | ||
_, err = wt.W.Lakeview.Update(ctx, dashboards.UpdateDashboardRequest{ | ||
DashboardId: oi.ResourceId, | ||
SerializedDashboard: dashboard.SerializedDashboard, | ||
}) | ||
require.NoError(t, err) | ||
|
||
// Try to redeploy the bundle and confirm that the out of band modification is detected. | ||
stdout, _, err := deployBundleWithArgs(t, ctx, root) | ||
require.Error(t, err) | ||
assert.Contains(t, stdout, `Error: dashboard "file_reference" has been modified remotely`+"\n") | ||
|
||
// Redeploy the bundle with the --force flag and confirm that the out of band modification is ignored. | ||
_, stderr, err := deployBundleWithArgs(t, ctx, root, "--force") | ||
require.NoError(t, err) | ||
assert.Contains(t, stderr, `Deployment complete!`+"\n") | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters