Feature: Add random number generator to AsyncRuntime
#995
Conversation
Up to now, the `rand` crate was used directly to generate random numbers for `openraft`. However, this has some drawback when integrating with other async runtimes. Expose the random number generator via `AsyncRuntime` abstraction and implement it by default via `rand::thread_rng()`.
There was a problem hiding this comment.
+reviewer:@drmingdrmer
This completes #943
Reviewable status: 0 of 4 files reviewed, all discussions resolved (waiting on @drmingdrmer)
openraft/src/config/config.rs line 251 at r1 (raw file):
impl Config { /// Generate a new random election timeout within the configured min & max. pub fn new_rand_election_timeout<RT: AsyncRuntime>(&self) -> u64 {
Instead of generalizing the types Config and EngineConfig I decided to just generalize respective methods to make the change minimal.
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @schreter)
openraft/src/config/config.rs line 251 at r1 (raw file):
Previously, schreter wrote…
Instead of generalizing the types
ConfigandEngineConfigI decided to just generalize respective methods to make the change minimal.
Looks good enough :)
Up to now, the
randcrate was used directly to generate random numbers foropenraft. However, this has some drawback when integrating with other async runtimes.Expose the random number generator via
AsyncRuntimeabstraction and implement it by default viarand::thread_rng().This change is