Change: remove N, LS from Raft<C, N, LS, _>
#940
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drmingdrmer
force-pushed
the
31-type-config
branch
from
d929e5b
to
a034382
Compare
- `Raft<C, ..>`: is a control handle of `RaftCore` and it does not directly rely on `N: RaftNetworkFactory`, `LS: RaftLogStorage` and `SM: RaftStateMachine`. Thus these types should not be part of `Raft`. In this commit, we remove `N, LS, SM` from `Raft<C, N, LS, SM>`, `RaftInner<C, N, LS>` and `RaftMsg<C, N, LS>`. Type `N, LS, SM` now are only used by `Raft::new()` which needs these types to create `RaftCore`. - `Raft::external_request()`: Another change is the signature of the `Fn` passed to `Raft::external_request()` changes from `FnOnce(&RaftState, &mut LS, &mut N)` to `FnOnce(&RaftState)`. - Fix: the `FnOnce` passed to `Raft::external_request()` should always be `Send`, unoptionally. Because it is used to send from `Raft` to `RaftCore`. - Fix: databendlabs#939
drmingdrmer
force-pushed
the
31-type-config
branch
from
a034382
to
182fe92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Change: remove
N, LSfromRaft<C, N, LS, _>Raft<C, ..>: is a control handle ofRaftCoreand it does not directlyrely on
N: RaftNetworkFactoryandLS: RaftLogStorage.Thus these two type should not be part of
Raft.In this commit, we remove
N, LSfromRaft<C, N, LS, SM>,RaftInner<C, N, LS>andRaftMsg<C, N, LS>.Type
N, LSnow is only used byRaft::new()which needs these twotypes to create
RaftCore.Raft::external_request(): Another change is the signature of theFnpassed toRaft::external_request()changes fromFnOnce(&RaftState, &mut LS, &mut N)toFnOnce(&RaftState).Fix: the
FnOncepassed toRaft::external_request()should alwaysbe
Send, unoptionally. Because it is used to send fromRafttoRaftCore.Fix: RaftMsg::ExternalRequest: should not rely on RaftLogStorage and RaftNetworkFactory #939
This change is