Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: update doc of heartbeat metric #1241

Merged
merged 1 commit into from
Sep 1, 2024

Conversation

SteveLauC
Copy link
Collaborator

@SteveLauC SteveLauC commented Sep 1, 2024

What does this PR do

Updates the doc of the heartbeat field of RaftMetrics and RaftDataMetrics as we store the timestamp itself rather than the duration since the last acknowledged heartbeat/replication timestamp since #1202.

Checklist

  • Updated guide with pertinent info (may not always apply).
  • Squash down commits to one or two logical commits which clearly describe the work you've done.
  • Unittest is a friend:)

This change is Reviewable

Copy link
Member

@drmingdrmer drmingdrmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SteveLauC)

@drmingdrmer drmingdrmer merged commit 0063194 into databendlabs:main Sep 1, 2024
32 checks passed
@SteveLauC SteveLauC deleted the Doc/heartbeat branch September 1, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants