Feature: Add TypeConfigExt to simplify RaftTypeConfig Access
#1145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drmingdrmer
force-pushed
the
83-type-ext
branch
2 times, most recently
from
29a8aab
to
7219828
Compare
schreter
previously approved these changes
Jul 3, 2024
There was a problem hiding this comment.
Nice!
Reviewed 17 of 17 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @drmingdrmer)
openraft/src/type_config/util.rs line 20 at r1 (raw file):
// Time related methods /// Returns the current time
Suggestion:
/// Returns the current time.openraft/src/type_config/util.rs line 50 at r1 (raw file):
// Synchronization methods fn oneshot<T>() -> (OneshotSenderOf<Self, T>, OneshotReceiverOf<Self, T>)
Maybe add docs to the method?
This commit introduces a new trait, `TypeConfigExt`, which extends `RaftTypeConfig`. The purpose of this trait is to simplify the access to various functionalities provided by the `RaftTypeConfig` trait, enhancing code readability and reducing complexity. **Methods Added to `TypeConfigExt`:** - `now()` - `sleep()` - `sleep_until()` - `timeout()` - `timeout_at()` - `oneshot()` - `spawn()` **Usage Improvement:** - Instead of using the `<<C as RaftTypeConfig>::AsyncRuntime as AsyncRuntime>::Instant::now()`, you can now simply call `C::now()`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Feature: Add
TypeConfigExtto simplifyRaftTypeConfigAccessThis commit introduces a new trait,
TypeConfigExt, which extendsRaftTypeConfig. The purpose of this trait is to simplify the access tovarious functionalities provided by the
RaftTypeConfigtrait,enhancing code readability and reducing complexity.
Methods Added to
TypeConfigExt:now()sleep()sleep_until()timeout()timeout_at()oneshot()spawn()Usage Improvement:
<<C as RaftTypeConfig>::AsyncRuntime as AsyncRuntime>::Instant::now(),you can now simply call
C::now().This change is