Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move TableInfo building out of SchemaApi #16548

Merged

Conversation

drmingdrmer
Copy link
Member

@drmingdrmer drmingdrmer commented Sep 30, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

fix: move TableInfo building out of SchemaApi

SchemaApi can not provide enough information such as CatalogInfo and
DatabaseType. Therefore SchemaApi should not build a TableInfo,
leave such task to its caller.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)

Related Issues


This change is Reviewable

@drmingdrmer drmingdrmer marked this pull request as ready for review September 30, 2024 04:07
@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Sep 30, 2024
`SchemaApi` can not provide enough information such as `CatalogInfo` and
`DatabaseType`. Therefore `SchemaApi` should not build a `TableInfo`,
leave such task to its caller.
@drmingdrmer drmingdrmer merged commit a1497e2 into databendlabs:main Sep 30, 2024
71 checks passed
@drmingdrmer drmingdrmer deleted the 153-get-gc-list-with-nivs branch September 30, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants