Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code improvements in Scala reference implementation #5

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

dbehrouz
Copy link

  • Use of more compact code
  • Use immutable objects in TF IDF computation
  • Fixed a bug in TF-IDF where the supplied input to the program was being ignored and a static location was being used as input.

@rmetzger
Copy link
Contributor

Thanks a lot for the pull request.
@fhueske has the full overview over the Flink training material. He just left for a one week vacation, so you'll have to wait until then ;)

But from my point of view, the changes look reasonable.

@mxm
Copy link
Contributor

mxm commented Aug 24, 2015

Thanks @bderak for your pull request. I agree with the Scala immutable object changes and the bug fixing in TF-IDF. However, it was intended for the code to not be very compact in order to make novices familiar with the general Flink transformations. It's not very Scala-esk I agree :)

@fhueske
Copy link
Contributor

fhueske commented Aug 25, 2015

Hi @bderak, thanks for the fixes! As @mxm said, we used groupReduce instead of sum on purpose to teach the concept of reduce. The other changes look very good.
Thanks, Fabian

@dbehrouz
Copy link
Author

dbehrouz commented Sep 1, 2015

great.
Sorry I was travelling as well these past weeks. I ll make the changes soon ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants