Update k8s deployment #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make service configurable (added loadBalancerSourceRanges, annotations, and labels). - Migrate off deprecated postgres chart. - Use standardized names for labels. - Add chart's api version.
|
I might follow up in another PR with an ingress to close off #28 |
wilko77
approved these changes
Nov 29, 2020
| global: | ||
| postgresql: | ||
| postgresqlDatabase: "postgres" | ||
| postgresqlUsername: "postgres" |
There was a problem hiding this comment.
someone really loves writing 'postgresql'.
Wouldn't it be more concise like that:
.Values.global.postgresql.password etc.
There was a problem hiding this comment.
Yeah it would but the keys come from the dependent chart's parameters not from me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tested that the labels and annotations work.