Issue #14: Generate eGUIDs from GUIDs - use raw bytes - code cleanup #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Work with data as raw bytes (not hex, not base64) when adding noise and encrypting Instead of calling bcrypt.hash() directly, wrap it in a method called phiHashFunction (which returns a hash in Uint8Array format) so that we can easily switch to another hashing function if necessary
Work with data as raw bytes (not hex, not base64) when adding noise and encrypting Fix bcrypt hash base64 decoding as bcrypt uses non-standardized base64 encoding
Fix bug that occurred when converting hash buffer to hex string representation
veronikaslc
force-pushed
the
issues-13-14
branch
3 times, most recently
from
5244f3e
to
18b11b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes several issues associated with the previously merged PR #17 namely:
phiHashFunctionfunction so that the hashing algorithm can easily be switched to a different one if needed and thephiHashFunctioncan be shared between both client and server Javascript programs. ThisphiHashFunctionfunction removes all non-hash information (eg. salt, version number, etc...) and returns the hash as aUint8Arrayof bytes.window.atob()does not work as bcrypt uses non-standardized base64 encoding andwindow.atob()cannot handle the.and/characters.To test:
Setting
enableObfuscationinproject-config.jsontofalsewill cause the application to generate GUIDs.Generated GUIDs should be deterministic - the same
<Health card,Province code,Date of birth>should always generate the same GUID.Changing even just one of the Health card, Province code, or Date of birth values should result in a different GUID.
Setting
enableObfuscationinproject-config.jsontotruewill cause the application to generate eGUIDs.Generated eGUIDs should be non-deterministic - the same
<Health card,Province code,Date of birth>should generate different eGUIDs.Test with the
issues-13-14_code-cleanup_testbranch and open the browser's web console. The value associated with theWorking with: ...message should deterministic with respect to the Health card, Province code, and Date of birth values, while the output displayed in the eGUID table column should be non-deterministic. The value associated with theRound-trip, base64 re-encoded to: ...message should always be the same as the value associated with the previousWorking with: ...message.