Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code-cleanup] Cleanup and minor optimisation of the Questions components params interchange #1607

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

veronikaslc
Copy link
Contributor

@veronikaslc veronikaslc commented Sep 29, 2023

Code refactoring/optimisation changes:

  • answerNodeType and isMultivalued are now calculated inside of the Answer component
  • removed explicit properties that duplicate the properties from the questionDefinition, now they are transfered to all Question components as part of the questionDefinition as it should be

Code cleanup changes:

  • removed unused imports
  • removed unused props
  • bundled props passed to Answer with {...rest}
  • cleaned up comments
  • removed text: PropTypes.string, from props passed to question components

@marta- marta- added the Test me! Ready for testing label Oct 10, 2023
@sashaandjic sashaandjic added the testing... Testing in progress label Jan 10, 2024
@marta- marta- marked this pull request as ready for review March 12, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low priority Test me! Ready for testing testing... Testing in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants