CARDS-2131: Increase test coverage cards-permissions #1417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veronikaslc
reviewed
Jun 16, 2023
| @Test | ||
| public void matchesForTreeWithoutResourceTypePropertyReturnsFalse() | ||
| { | ||
| NodeBuilderTree tree = new NodeBuilderTree(UUID.randomUUID().toString(), EmptyNodeState.EMPTY_NODE.builder()); |
There was a problem hiding this comment.
missed test case of tree created from sling:resourceType other than cards/Form
veronikaslc
reviewed
Jun 16, 2023
| @Test | ||
| public void matchesForTreeWithoutResourceSuperTypePropertyReturnsFalse() | ||
| { | ||
| NodeBuilderTree tree = new NodeBuilderTree(UUID.randomUUID().toString(), EmptyNodeState.EMPTY_NODE.builder()); |
There was a problem hiding this comment.
missed test case of tree created from sling:resourceType other than cards/Answer
veronikaslc
reviewed
Jun 16, 2023
| @Test | ||
| public void matchesForTreeWithoutResourceSuperTypePropertyReturnsFalse() | ||
| { | ||
| NodeBuilderTree tree = new NodeBuilderTree(UUID.randomUUID().toString(), EmptyNodeState.EMPTY_NODE.builder()); |
There was a problem hiding this comment.
missed test case of tree created from sling:resourceType other than cards/AnswerSection
|
|
|
|
|
jacoco.zip |
sofi2002sofi
force-pushed
the
CARDS-2131-permissions-test
branch
from
7433108
to
0912d65
Compare
…trictionPattern, SectionRestrictionPattern and SessionSubjectRestrictionPattern
sdumitriu
force-pushed
the
CARDS-2131-permissions-test
branch
from
0912d65
to
ef9b731
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.