-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CloudSql PostegreSql e2e test scenarios #200
base: develop
Are you sure you want to change the base?
CloudSql PostegreSql e2e test scenarios #200
Conversation
cloudSqlPSQL related test scenarios
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should have separate tests for source and sink plugins
@@ -0,0 +1,103 @@ | |||
<?xml version="1.0" encoding="UTF-8"?> | |||
<!-- | |||
Copyright © 2015-2019 Cask Data, Inc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2022
@@ -0,0 +1,45 @@ | |||
Feature: CloudSQLPostgreSQL Sink and Error Validation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Capitalize first letter in filename - cloudSql -> CloudSql
@Then("Enter the CloudSQLPostgreSQL Source Properties with blank property {string}") | ||
public void enterTheCloudSQLPostgreSQLSourcePropertiesWithBlankProperty(String property) throws IOException, | ||
InterruptedException { | ||
if (property.equalsIgnoreCase("referenceName")) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
avoid code duplication
} | ||
|
||
@Then("Verify error is displayed for incorrect Connection Name with private instance type") | ||
public void verifyTheCldMySqlInvalidPrivate() throws InterruptedException { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix name
@Then("Enter the CloudSQLPostgreSQL Sink Properties with blank property {string}") | ||
public void enterTheCloudSQLPostgreSQLSinkPropertiesWithBlankProperty(String property) throws IOException, | ||
InterruptedException { | ||
if (property.equalsIgnoreCase("referenceName")) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
avoid code duplication
} | ||
|
||
@Then("Enter Connection Name with private instance type") | ||
public void enterTheInvalidPrivate() throws InterruptedException, IOException { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where is this used? also, please rename to something more meaningful
@tivv @rmstar @itsankit-google Please review.