Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add killed and injured count per age group stacked #1161

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from

Conversation

ReutSher1
Copy link

#1160 add killed and injured count per age group stacked Widge

@atalyaalon
Copy link
Contributor

@shaked-hayek can you review?

Copy link
Collaborator

@shaked-hayek shaked-hayek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, please fix my comments

src/components/molecules/GenericBarChart.tsx Outdated Show resolved Hide resolved
src/components/molecules/GenericBarChart.tsx Outdated Show resolved Hide resolved
src/models/WidgetData.ts Outdated Show resolved Hide resolved
src/const/cards.const.ts Outdated Show resolved Hide resolved
src/services/widgets.data.service.ts Outdated Show resolved Hide resolved
src/utils/barChart.utils.ts Outdated Show resolved Hide resolved
src/utils/barChart.utils.ts Outdated Show resolved Hide resolved
src/components/organisms/WidgetsTemplate.tsx Outdated Show resolved Hide resolved
@@ -196,4 +196,4 @@ export interface IWidgetKilledAndInjuredCountPerAgeGroup extends IWidgetDataBase
subtitle?: string;
title?: string;
};
}
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here as well

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't show spaces in the source code here

Copy link
Collaborator

@shaked-hayek shaked-hayek Nov 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think maybe you added a new line after

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants