Common select fixes #1449
Merged
Common select fixes #1449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1449 +/- ##
=======================================
Coverage 94.48% 94.49%
=======================================
Files 210 210
Lines 3971 3975 +4
Branches 1628 1629 +1
=======================================
+ Hits 3752 3756 +4
Misses 219 219 ☔ View full report in Codecov by Sentry. |
|
🙏 |
3 tasks
rvsia
reviewed
Mar 21, 2024
| @@ -69,9 +69,16 @@ const useSelect = ({ | |||
| simpleValue, | |||
| compareValues, | |||
| }) => { | |||
| const [state, originalDispatch] = useReducer(reducer, { optionsTransformer, propsOptions }, init); | |||
| const [propsOptions, setPropsCache] = useState(initialOptions); | |||
| const [state, originalDispatch] = useReducer(reducer, { optionsTransformer, propsOptions: initialOptions }, init); | |||
| const dispatch = (action) => originalDispatch({ ...action, optionsTransformer }); | |||
There was a problem hiding this comment.
We can pass the compareValues here so no need to pass it to all following dispatches
Comment on lines
124
to
125
| if (!isEqual(state.options, propsOptions)) { | ||
| if (state.isInitialLoaded) { |
| const dispatch = (action) => originalDispatch({ ...action, optionsTransformer }); | ||
|
|
||
| useEffect(() => { | ||
| if (!isEqual(initialOptions, propsOptions)) { |
There was a problem hiding this comment.
Can it lead to performance issues? 🤔
There was a problem hiding this comment.
For massive arrays of options it could, but as it stands infinite render loops are way worse.
Hyperkid123
force-pushed
the
mui-searchable-async-select
branch
from
30d1a88
to
23a38f5
Compare
rvsia
approved these changes
Mar 21, 2024
|
🎉 This PR is included in version 3.22.4 🎉 The release is available on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1448
Description
compareValuesincluded in select promises payload