Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation: number value validation example #1425

Merged

Conversation

mdomarus
Copy link
Contributor

Description

Update a number value validation example (threshold / value).

Checklist: (please see documentation page for more information)

  • Yarn build passes
  • Yarn lint passes
  • Yarn test passes
  • Test coverage for new code (if applicable)
  • Documentation update (if applicable)
  • Correct commit message
    • format fix|feat({scope}): {description}
    • i.e. fix(pf3): wizard correctly handles next button
    • fix will release a new _._.X version
    • feat will release a new _.X._ version (use when you introduce new features)
      • we want to avoid any breaking changes, please contact us, if there is no way how to avoid them
    • scope: package
    • if you update the documentation or tests, do not use this format
      • i.e. Fix button on documenation example page

Copy link

vercel bot commented Nov 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-forms ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2023 1:29pm

@DataDrivenFormsBot
Copy link

No new version will be released. Current: v3.22.0 [DataDrivenFormsBot]

@rvsia rvsia added bug Something isn't working docs docs pull requests labels Nov 20, 2023
Copy link
Contributor

@rvsia rvsia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! ❤️

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e1b5f8d) 94.91% compared to head (7cfed4c) 94.91%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1425   +/-   ##
=======================================
  Coverage   94.91%   94.91%           
=======================================
  Files         210      210           
  Lines        3697     3697           
  Branches     1289     1289           
=======================================
  Hits         3509     3509           
  Misses        188      188           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rvsia rvsia merged commit c14b085 into data-driven-forms:master Nov 20, 2023
6 checks passed
@rvsia rvsia added the released label Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working docs docs pull requests released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants