Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mui): Correctly use onBlur and onFocus for MUIDatePicker and MUITimePicker #1419

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

DNahr
Copy link
Contributor

@DNahr DNahr commented Nov 3, 2023

Description

onBlur and onFocus weren't called for MUIDatePicker and MUITimePicker. Can be tested in the mui playground. Required validation won't be displayed without these changes because meta.touched never gets set.

Schema (if applicable)

Checklist: (please see documentation page for more information)

  • Yarn build passes
  • Yarn lint passes
  • Yarn test passes
  • Test coverage for new code (if applicable)
  • Documentation update (if applicable)
  • Correct commit message
    • format fix|feat({scope}): {description}
    • i.e. fix(pf3): wizard correctly handles next button
    • fix will release a new _._.X version
    • feat will release a new _.X._ version (use when you introduce new features)
      • we want to avoid any breaking changes, please contact us, if there is no way how to avoid them
    • scope: package
    • if you update the documentation or tests, do not use this format
      • i.e. Fix button on documenation example page

Copy link

vercel bot commented Nov 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-forms ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 3, 2023 7:19pm

@DataDrivenFormsBot
Copy link

A new version (fix) will be released: v3.21.9 [DataDrivenFormsBot]

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #1419 (c4c9222) into master (a1b587b) will not change coverage.
Report is 1 commits behind head on master.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1419   +/-   ##
=======================================
  Coverage   94.96%   94.96%           
=======================================
  Files         210      210           
  Lines        3672     3672           
  Branches     1284     1284           
=======================================
  Hits         3487     3487           
  Misses        185      185           
Files Coverage Δ
...ui-component-mapper/src/date-picker/date-picker.js 81.81% <ø> (ø)
...ui-component-mapper/src/time-picker/time-picker.js 81.81% <ø> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@rvsia rvsia added bug Something isn't working MUI MUI pull request labels Nov 6, 2023
@rvsia rvsia merged commit 208c9a2 into data-driven-forms:master Nov 6, 2023
6 checks passed
@rvsia rvsia added the released label Nov 6, 2023
@DNahr DNahr deleted the mui-date-and-time-picker branch November 6, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working MUI MUI pull request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants