fix(pf): bug in wizard navbar #1416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
A new version (fix) will be released: v3.21.8 [DataDrivenFormsBot] |
The wizard navigation should only contain one WizardNav component. Wrapping the WizardNavItems in two WizardNav components is causing all steps to be treated as substeps and therefore don't have step numbers. The fix is to remove one of the WizardNav wrappers.
jkozol
force-pushed
the
bugfix-pf5-wizard
branch
from
4ae5383
to
96c82c0
Compare
Codecov Report
@@ Coverage Diff @@
## master #1416 +/- ##
=======================================
Coverage 94.96% 94.96%
=======================================
Files 210 210
Lines 3672 3672
Branches 1284 1284
=======================================
Hits 3487 3487
Misses 185 185
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
rvsia
approved these changes
Oct 24, 2023
|
🎉 This PR is included in version 3.21.8 🎉 The release is available on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Image Builder wizard we are no longer seeing step numbers with the pf5 upgrade.
The wizard navigation should only contain one WizardNav component. Wrapping the WizardNavItems in two WizardNav components is causing all steps to be treated as substeps and therefore don't have step numbers. The fix is to remove one of the WizardNav wrappers.
The other WizardNav component is here:
react-forms/packages/pf4-component-mapper/src/wizard/wizard.js
Line 129 in baaf600
And here is a screenshot of the issue.