fix(pf4): fix bug in wizard navigation toolbar #1414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Patternfly 4, the WizardNavItem component `step` prop is "the step passed into the onNavItemClick callback". http://v4-archive.patternfly.org/v4/components/wizard#wizardnavitem In Patternfly 5, onNavItemClick no longer exists. Instead, there is an onClick callback which expects the index of the step to be navigated to. https://www.patternfly.org/components/wizard/#wizardnavitem However, filtering the navSchema like so: `.filter((field) => field.primary)` results in substeps with field.primary===false being dropped. Practically, this means the 2nd substep and those following it. Therefore, the index provided by `.map((step, ind) => ...` is incorrect. The correct index can still be found from `step.index`.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
A new version (fix) will be released: v3.21.7 [DataDrivenFormsBot] |
Codecov Report
@@ Coverage Diff @@
## master #1414 +/- ##
=======================================
Coverage 94.96% 94.96%
=======================================
Files 210 210
Lines 3672 3672
Branches 1284 1284
=======================================
Hits 3487 3487
Misses 185 185
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Hyperkid123
approved these changes
Oct 16, 2023
|
🎉 This PR is included in version 3.21.7 🎉 The release is available on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Patternfly 4, the WizardNavItem component
stepprop is "the step passed into the onNavItemClick callback".http://v4-archive.patternfly.org/v4/components/wizard#wizardnavitem
In Patternfly 5, onNavItemClick no longer exists. Instead, there is an onClick callback which expects the index of the step to be navigated to.
https://www.patternfly.org/components/wizard/#wizardnavitem
However, filtering the navSchema like so:
.filter((field) => field.primary)results in substeps with field.primary===false being dropped. Practically, this means the 2nd substep and those following it. Therefore, the index provided by.map((step, ind) => ...is incorrect.The correct index can still be found from
step.index.We first encountered a bug related to this while upgrading our app to PF5, see the PR here:
osbuild/image-builder-frontend#1365 (comment)