Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mui): Move date pickers to peer dependencies. #1411

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

Hyperkid123
Copy link
Member

Resolves issues with duplicate dependencies on yarn and relaxes the restriction of the package version.

Fixes: #1409

Checklist: (please see documentation page for more information)

  • Yarn build passes
  • Yarn lint passes
  • Yarn test passes
  • Test coverage for new code (if applicable)
  • Correct commit message
    • format fix|feat({scope}): {description}
    • i.e. fix(pf3): wizard correctly handles next button
    • fix will release a new _._.X version
    • feat will release a new _.X._ version (use when you introduce new features)
      • we want to avoid any breaking changes, please contact us, if there is no way how to avoid them
    • scope: package
    • if you update the documentation or tests, do not use this format
      • i.e. Fix button on documenation example page

@vercel
Copy link

vercel bot commented Sep 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-forms ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 14, 2023 8:34am

@DataDrivenFormsBot
Copy link

A new version (fix) will be released: v3.21.5 [DataDrivenFormsBot]

Resolves issues with duplicate dependencies on yarn and relaxes the
restriction of the package version.

Fixes: #1409
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #1411 (c95f59c) into master (4785253) will decrease coverage by 0.11%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1411      +/-   ##
==========================================
- Coverage   95.09%   94.98%   -0.11%     
==========================================
  Files         209      209              
  Lines        3648     3650       +2     
  Branches     1273     1275       +2     
==========================================
- Hits         3469     3467       -2     
- Misses        179      183       +4     
Files Changed Coverage Δ
...ui-component-mapper/src/date-picker/date-picker.js 81.81% <100.00%> (-18.19%) ⬇️
...ui-component-mapper/src/time-picker/time-picker.js 81.81% <100.00%> (-18.19%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rvsia rvsia added MUI MUI pull request dependencies Dependency PR labels Sep 14, 2023
@Hyperkid123 Hyperkid123 merged commit d919ab7 into master Sep 14, 2023
5 of 6 checks passed
@Hyperkid123 Hyperkid123 deleted the mui-date-picker branch September 14, 2023 09:27
@rvsia rvsia added the released label Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Dependency PR MUI MUI pull request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not able to render date picker component for MUI
3 participants