Skip to content

Commit

Permalink
fix(common): useSelect rendering loop
Browse files Browse the repository at this point in the history
  • Loading branch information
Hyperkid123 committed Mar 21, 2024
1 parent 271e466 commit 2a9ace4
Showing 1 changed file with 7 additions and 5 deletions.
12 changes: 7 additions & 5 deletions packages/common/src/use-select/use-select.js
Original file line number Diff line number Diff line change
Expand Up @@ -114,12 +114,14 @@ const useSelect = ({
}, [loadOptionsStr, loadOptionsChangeCounter]);

useEffect(() => {
if (state.isInitialLoaded) {
if (!noValueUpdates && value && !propsOptions.map(({ value }) => value).includes(value)) {
onChange(undefined);
}
if (!isEqual(state.options, propsOptions)) {
if (state.isInitialLoaded) {
if (!noValueUpdates && value && !propsOptions.map(({ value }) => value).includes(value)) {
onChange(undefined);
}

dispatch({ type: 'setOptions', payload: propsOptions });
dispatch({ type: 'setOptions', payload: propsOptions });
}
}
}, [propsOptions]);

Expand Down

0 comments on commit 2a9ace4

Please sign in to comment.