Skip to content

Commit

Permalink
Fix based on linter feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
pflooky committed Jun 25, 2024
1 parent 3049f73 commit 5656742
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 10 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -62,4 +62,4 @@ jobs:

- name: Print Output
id: output
run: echo "${{ steps.test-action.outputs.time }}"
run: echo "${{ steps.test-action.outputs.results }}"
19 changes: 10 additions & 9 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -204,15 +204,15 @@ steps:
run: echo "${{ steps.run-action.outputs.time }}"
```

# Automatic Integration Tests via GitHub Actions
## Automatic Integration Tests via GitHub Actions

1. Create pull request
2. Triggers GitHub action
3. Sets up services via insta-infra
4. Data generated via data-caterer
5. Results published to pull request
1. Triggers GitHub action
1. Sets up services via insta-infra
1. Data generated via data-caterer
1. Results published to pull request

# Setup
## Setup

- Create new GitHub application
- Follows similar flow to renovatebot
Expand All @@ -222,14 +222,14 @@ steps:
requirements.txt, etc.)
- Users can manually add the services their app interacts with (i.e.
Postgres, MySQL)
- The target repo could be one or more apps/jobs
- The target repository could be one or more apps/jobs
- Need to know how to run their app/job
- Use docker image by default, otherwise build and start script could be
provided by user
- Use default credentials of each service
- Ability to define custom data generation/validation with YAML

# Example Flow
### Example Flow

GitHub Action YAML

Expand Down Expand Up @@ -260,7 +260,8 @@ services: #what external services your app/job connects to
run: #how to run your app/job, can run multiple, run in order
- command: ./run-app.sh
# command: java -jar build/target/my-app.jar
# command: docker run -p 8080:8080 my-image:${APP_VERSION:-1.3.1} #allow for env variable substitution anywhere in the YAML
# command: docker run -p 8080:8080 my-image:${APP_VERSION:-1.3.1}
#allow for env variable substitution anywhere in the YAML
env:
- APP_VERSION=1.3.1
test: #using data-caterer, generate and validate data
Expand Down

0 comments on commit 5656742

Please sign in to comment.