Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor some tests #8908

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Refactor some tests #8908

merged 2 commits into from
Oct 25, 2024

Conversation

fjetter
Copy link
Member

@fjetter fjetter commented Oct 25, 2024

This refactors two tests that are very flaky.

test_deadlock_cancelled_after_inflight_before_gather_from_worker

(I was initially able to reproduce this when running the test a couple thousand times. The windows CI is really slow it seems)

image

and

test_restarting_during_transfer_raises_killed_worker

image

Both appear to be stable now on my machine

Copy link
Contributor

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

    25 files  +    1      25 suites  +1   10h 25m 49s ⏱️ + 29m 15s
 4 121 tests  -     2   4 007 ✅  -     2    110 💤 ± 0  4 ❌ ±0 
47 598 runs  +2 655  45 506 ✅ +2 592  2 087 💤 +63  5 ❌ ±0 

For more details on these failures, see this check.

Results for commit 349136d. ± Comparison against base commit 928d770.

This pull request removes 2 tests.
distributed.tests.test_cancelled_state ‑ test_deadlock_cancelled_after_inflight_before_gather_from_worker[False-cancelled]
distributed.tests.test_cancelled_state ‑ test_deadlock_cancelled_after_inflight_before_gather_from_worker[False-resumed]

@fjetter fjetter merged commit 1205a70 into dask:main Oct 25, 2024
26 of 33 checks passed
@fjetter fjetter deleted the refactor_some_tests branch October 25, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant