Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase connect timeout for test_tell_workers_when_peers_have_left #8906

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

fjetter
Copy link
Member

@fjetter fjetter commented Oct 24, 2024

I hope that this will resolve the flakynes of this test. My hypothesis is that GH actions is just so slow that this test is actually running for a while.

If the feature is actually flaky/broken, this test will now give a strong signal since we'll run in a proper test timeout

Copy link
Member

@hendrikmakait hendrikmakait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @fjetter, looks reasonable to me

Copy link
Contributor

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

    25 files  +    1      25 suites  +1   10h 28m 55s ⏱️ + 30m 23s
 4 132 tests ±    0   4 016 ✅ ±    0    110 💤  -  1  6 ❌ +1 
47 730 runs  +1 413  45 629 ✅ +1 371  2 095 💤 +41  6 ❌ +1 

For more details on these failures, see this check.

Results for commit ee5ffa7. ± Comparison against base commit 48509b3.

@hendrikmakait hendrikmakait merged commit af01543 into dask:main Oct 24, 2024
26 of 33 checks passed
@fjetter fjetter deleted the test_fix_workers_peers branch October 24, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants