Fix test nanny timeout #8847
Merged
Fix test nanny timeout #8847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 25 files ± 0 25 suites ±0 10h 9m 45s ⏱️ - 7m 53s For more details on these failures, see this check. Results for commit a325253. ± Comparison against base commit ac7a24e. This pull request removes 1 and adds 4 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
hendrikmakait
approved these changes
Sep 2, 2024
distributed/tests/test_nanny.py
Outdated
| async def try_to_kill_nanny(): | ||
| while not nanny.process or nanny.process.status not in ( | ||
| Status.starting, # this is what we want | ||
| # Status.failed # we might've missed it already |
There was a problem hiding this comment.
Suggested change
| # Status.failed # we might've missed it already |
|
This still has a problem... |
Alright, just let me know once it's ready for a final review. CI looked good though 🙈 |
|
@hendrikmakait should be good to go now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be fixing
distributed.tests.test_nanny.test_nanny_timeoutwhich appears to be caused by a race condition between startup and kill.That condition is now tested in a dedicated test
test_worker_start_exception_while_killing