-
-
Notifications
You must be signed in to change notification settings - Fork 718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce memory footprint of culling P2P rechunking #8845
Reduce memory footprint of culling P2P rechunking #8845
Conversation
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 25 files ±0 25 suites ±0 10h 15m 38s ⏱️ - 6m 8s For more details on these failures, see this check. Results for commit 4db28ae. ± Comparison against base commit 4aeed40. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @hendrikmakait, I can confirm this drastically reduces the memory required to kick off some of the large ERA5 rechunking jobs I've been running lately. (@dcherian you may also find this one interesting)
you guys are killing it :) |
Benchmarking on Coiled showed no impact on performance (https://github.com/coiled/benchmarks/actions/runs/10628454825). Note that we do not measure client-side memory. |
thanks! |
Previously, culling appeared to have an exponentially-growing memory footprint, this PR fixes that.
pre-commit run --all-files