Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dump cluster from gen_cluster #8823

Merged
merged 3 commits into from
Aug 23, 2024

Conversation

fjetter
Copy link
Member

@fjetter fjetter commented Aug 7, 2024

I don't see a lot of value for having this still around. However, it is spamming the working directory and makes test execution (if failed) much slower.

Copy link
Contributor

github-actions bot commented Aug 7, 2024

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

    25 files  ± 0      25 suites  ±0   10h 9m 33s ⏱️ - 6m 10s
 4 099 tests  -  6   3 981 ✅  -  3    113 💤 ±0  5 ❌  - 3 
47 366 runs   - 72  45 232 ✅  - 69  2 129 💤 ±0  5 ❌  - 3 

For more details on these failures, see this check.

Results for commit f97062d. ± Comparison against base commit 3075b08.

This pull request removes 6 tests.
distributed.tests.test_utils_test ‑ test_dump_cluster_state
distributed.tests.test_utils_test ‑ test_dump_cluster_state_nannies
distributed.tests.test_utils_test ‑ test_dump_cluster_state_no_workers
distributed.tests.test_utils_test ‑ test_dump_cluster_state_timeout
distributed.tests.test_utils_test ‑ test_dump_cluster_state_unresponsive_local_worker
distributed.tests.test_utils_test ‑ test_dump_cluster_unresponsive_remote_worker

♻️ This comment has been updated with latest results.

@hendrikmakait hendrikmakait self-requested a review August 12, 2024 14:04
@hendrikmakait
Copy link
Member

CI isn't happy with this PR, need help fixing this up?

@fjetter fjetter force-pushed the remove_dump_cluster_from_gen_cluster branch from 6940a3d to 0173ffb Compare August 16, 2024 09:44
Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fjetter. I left one non-blocking comment but otherwise this LGTM

@@ -1122,41 +1106,6 @@ async def async_fn_outer():
return _


async def dump_cluster_state(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another option is to leave this functionality around but still disable it in gen_cluster. I'm not sure how much value there is to having dump_cluster_state around for diagnosing tricky deadlock situations.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The functionality itself is part of Client. I'm not entirely sure what this utility function offers but I'd rather not maintain it.

@fjetter fjetter merged commit c073797 into dask:main Aug 23, 2024
25 of 32 checks passed
@fjetter fjetter deleted the remove_dump_cluster_from_gen_cluster branch August 23, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants