Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix restarting workers with PackageInstall plugin #8794

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

hendrikmakait
Copy link
Member

Closes #8791

#8781 caused a regression in 2024.7.1 where the worker restart via nanny plugins stopped working. This PR fixes that.

  • Tests added / passed
  • Passes pre-commit run --all-files

Copy link
Contributor

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

    29 files  +    1      29 suites  +1   12h 3m 46s ⏱️ + 31m 0s
 4 091 tests ±    0   3 971 ✅  -     6    112 💤  -  1  8 ❌ +7 
55 339 runs  +1 430  52 892 ✅ +1 374  2 439 💤 +62  8 ❌  - 6 

For more details on these failures, see this check.

Results for commit d22e69d. ± Comparison against base commit 222e047.

@hendrikmakait hendrikmakait merged commit 7013e2e into dask:main Jul 23, 2024
25 of 35 checks passed
@hendrikmakait hendrikmakait deleted the fix-package-install-plugin branch July 23, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_package_install_restarts_on_nanny times out
2 participants