-
-
Notifications
You must be signed in to change notification settings - Fork 718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add another test for a possible deadlock scenario caused by #8703 #8769
Add another test for a possible deadlock scenario caused by #8703 #8769
Conversation
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 29 files + 8 29 suites +8 11h 57m 37s ⏱️ + 4h 30m 44s For more details on these failures, see this check. Results for commit ac2c5f5. ± Comparison against base commit 48eefee. This pull request removes 1 and adds 6 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
distributed/tests/test_scheduler.py
Outdated
await async_poll_for( | ||
lambda: b.state.tasks.get(dep_key) is not None | ||
and b.state.tasks.get(dep_key).state == "memory", | ||
timeout=5, | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test is a little ambiguous. This could either mean that B computed the result or that it fetched it. Both will take different code paths.
This is a likely source for a flaky test that'll be hard to track down
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uff, I was already wondering why this test failed on some CI runs but never locally!
distributed/tests/test_scheduler.py
Outdated
for i in range(s.total_nthreads * 2 + 1) | ||
] | ||
dep_key = dep.key | ||
del dep |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit/hint: In tests I often use dep.release()
which is pretty much the same but you have access to the key later on. Also, in case there is some reference to this it will still be released.
This is style, feel free to ignore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, good point, I didn't think of this!
Addendum to #8703 adding a test for another deadlock scenario.
pre-commit run --all-files