Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add drain option to dask-worker #8752

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Conversation

AlecThomson
Copy link

Closes #3141

  • Tests added / passed
  • Passes pre-commit run --all-files

Need some help on adding appropriate tests for this option

@AlecThomson AlecThomson requested a review from fjetter as a code owner July 6, 2024 07:24
@GPUtester
Copy link
Collaborator

Can one of the admins verify this patch?

Admins can comment ok to test to allow this one PR to run or add to allowlist to allow all future PRs from the same author to run.

Copy link
Contributor

github-actions bot commented Jul 6, 2024

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

    29 files  ±0      29 suites  ±0   11h 17m 37s ⏱️ + 3m 35s
 4 083 tests ±0   3 963 ✅  - 2    112 💤 ±0   8 ❌ +2 
55 230 runs  ±0  52 788 ✅  - 1  2 432 💤  - 1  10 ❌ +2 

For more details on these failures, see this check.

Results for commit 226c8b3. ± Comparison against base commit 8564dc7.

♻️ This comment has been updated with latest results.

@AlecThomson
Copy link
Author

Found that drain was not blocking additional tasks from being scheduled. Fixed with additional call to self.scheduler.retire_workers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement Request - Dask Workers lifetime option not waiting for job to finish
2 participants